Skip to content

Commit

Permalink
[PATCH] fix lockdep-design.txt
Browse files Browse the repository at this point in the history
I was looking at lockdep-desing.txt and i guess i am confused with the
changes with respect to fd7bcea. It
says

+   '.'  acquired while irqs enabled
+   '+'  acquired in irq context
+   '-'  acquired in process context with irqs disabled
+   '?'  read-acquired both with irqs enabled and in irq context
+

But the get_usage_chars() function does this for '-'
 if (class->usage_mask & LOCKF_ENABLED_HARDIRQS)
                        *c1 = '-';

So i guess what would be correct would be
'.'  acquired while irqs disabled
'+'  acquired in irq context
'-'  acquired with irqs enabled
'?' read acquired in irq context with irqs enabled.

Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Aneesh Kumar authored and Linus Torvalds committed Oct 11, 2006
1 parent 3dc3099 commit 5fcce74
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Documentation/lockdep-design.txt
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ The bit position indicates hardirq, softirq, hardirq-read,
softirq-read respectively, and the character displayed in each
indicates:

'.' acquired while irqs enabled
'.' acquired while irqs disabled
'+' acquired in irq context
'-' acquired in process context with irqs disabled
'?' read-acquired both with irqs enabled and in irq context
'-' acquired with irqs enabled
'?' read acquired in irq context with irqs enabled.

Unused mutexes cannot be part of the cause of an error.

Expand Down

0 comments on commit 5fcce74

Please sign in to comment.