Skip to content

Commit

Permalink
mmc: vub300: add missing usb_free_urb
Browse files Browse the repository at this point in the history
Add missing usb_free_urb on failure path after usb_alloc_urb.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@km exists@
local idexpression e;
expression e1,e2,e3;
type T,T1;
identifier f;
@@

* e = usb_alloc_urb(...)
... when any
    when != e = e1
    when != e1 = (T)e
    when != e1(...,(T)e,...)
    when != &e->f
if(...) { ... when != e2(...,(T1)e,...)
                 when != e3 = e
                 when forall
(
             return <+...e...+>;
|
*             return ...;
) }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Chris Ball <cjb@laptop.org>
  • Loading branch information
Julia Lawall authored and Chris Ball committed Sep 4, 2012
1 parent 4ee7ed0 commit 5fdb450
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mmc/host/vub300.c
Original file line number Diff line number Diff line change
Expand Up @@ -2358,9 +2358,9 @@ static int vub300_probe(struct usb_interface *interface,
* which is contained at the end of struct mmc
*/
error4:
usb_free_urb(command_out_urb);
error1:
usb_free_urb(command_res_urb);
error1:
usb_free_urb(command_out_urb);
error0:
return retval;
}
Expand Down

0 comments on commit 5fdb450

Please sign in to comment.