Skip to content

Commit

Permalink
[PATCH] Fix phy id for LXT971A/LXT972A
Browse files Browse the repository at this point in the history
From: Uwe Zeisberger <Uwe_Zeisberger@digi.com>

The phy ids used are taken from an driver that used a right shift of 4 to chop
off the revision number.  This driver does not shift, so the id and mask
values are wrong and must be left shifted by 4 to actually detect the chips.

Signed-off-by: Uwe Zeisberger <Uwe_Zeisberger@digi.com>
Acked-by: Andy Fleming <afleming@freescale.com>

[akpm: this is a previously-nacked patch, but the problem is real]
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Uwe Zeisberger authored and Jeff Garzik committed Jun 27, 2006
1 parent 5d22a31 commit 600991b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/phy/lxt.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,9 @@ static int lxt971_config_intr(struct phy_device *phydev)
}

static struct phy_driver lxt970_driver = {
.phy_id = 0x07810000,
.phy_id = 0x78100000,
.name = "LXT970",
.phy_id_mask = 0x0fffffff,
.phy_id_mask = 0xfffffff0,
.features = PHY_BASIC_FEATURES,
.flags = PHY_HAS_INTERRUPT,
.config_init = lxt970_config_init,
Expand All @@ -137,9 +137,9 @@ static struct phy_driver lxt970_driver = {
};

static struct phy_driver lxt971_driver = {
.phy_id = 0x0001378e,
.phy_id = 0x001378e0,
.name = "LXT971",
.phy_id_mask = 0x0fffffff,
.phy_id_mask = 0xfffffff0,
.features = PHY_BASIC_FEATURES,
.flags = PHY_HAS_INTERRUPT,
.config_aneg = genphy_config_aneg,
Expand Down

0 comments on commit 600991b

Please sign in to comment.