Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 136450
b: refs/heads/master
c: c6e50f9
h: refs/heads/master
v: v3
  • Loading branch information
Tejun Heo committed Jan 20, 2009
1 parent 93d0612 commit 6024990
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 19 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 5cdc5e9e69d4dc3a3630ae1fa666401b2a8dcde6
refs/heads/master: c6e50f93db5bd0895ec7c7d1b6f3886c6e1f11b6
2 changes: 0 additions & 2 deletions trunk/arch/x86/include/asm/pda.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,4 @@ extern void pda_init(int);

#endif

#define refresh_stack_canary() write_pda(stack_canary, current->stack_canary)

#endif /* _ASM_X86_PDA_H */
13 changes: 6 additions & 7 deletions trunk/arch/x86/include/asm/stackprotector.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,12 @@ static __always_inline void boot_init_stack_canary(void)
u64 tsc;

/*
* If we're the non-boot CPU, nothing set the PDA stack
* canary up for us - and if we are the boot CPU we have
* a 0 stack canary. This is a good place for updating
* it, as we wont ever return from this function (so the
* invalid canaries already on the stack wont ever
* trigger).
*
* Build time only check to make sure the stack_canary is at
* offset 40 in the pda; this is a gcc ABI requirement
*/
BUILD_BUG_ON(offsetof(struct x8664_pda, stack_canary) != 40);

/*
* We both use the random pool and the current TSC as a source
* of randomness. The TSC only matters for very early init,
* there it already has some randomness on most systems. Later
Expand Down
2 changes: 0 additions & 2 deletions trunk/arch/x86/kernel/apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -1131,9 +1131,7 @@ void __cpuinit setup_local_APIC(void)
int i, j;

if (disable_apic) {
#ifdef CONFIG_X86_IO_APIC
disable_ioapic_setup();
#endif
return;
}

Expand Down
7 changes: 0 additions & 7 deletions trunk/arch/x86/kernel/process_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -638,13 +638,6 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p)
percpu_write(kernel_stack,
(unsigned long)task_stack_page(next_p) +
THREAD_SIZE - KERNEL_STACK_OFFSET);
#ifdef CONFIG_CC_STACKPROTECTOR
/*
* Build time only check to make sure the stack_canary is at
* offset 40 in the pda; this is a gcc ABI requirement
*/
BUILD_BUG_ON(offsetof(struct x8664_pda, stack_canary) != 40);
#endif

/*
* Now maybe reload the debug registers and handle I/O bitmaps
Expand Down

0 comments on commit 6024990

Please sign in to comment.