Skip to content

Commit

Permalink
drm/i915/execbuffer: On error, starting unwinding from the previous o…
Browse files Browse the repository at this point in the history
…bject

As the error occurred on the current object, it means that its state was
not changed and so it should be excluded from the unwind.

Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Chris Wilson committed Nov 28, 2010
1 parent 432e58e commit 602606a
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/i915/i915_gem_execbuffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,9 @@ i915_gem_execbuffer_reserve(struct drm_device *dev,
} while (1);

err:
obj = list_entry(obj->exec_list.prev,
struct drm_i915_gem_object,
exec_list);
while (objects != &obj->exec_list) {
if (obj->gtt_space)
i915_gem_object_unpin(obj);
Expand Down

0 comments on commit 602606a

Please sign in to comment.