Skip to content

Commit

Permalink
staging: comedi: ni_670x: remove spurious free_irq() call
Browse files Browse the repository at this point in the history
This driver's comedi `detach` handler (`ni_670x_detach()`) calls
`free_irq()` but the driver doesn't call `request_irq()` anywhere.
Remove the spurious call.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ian Abbott authored and Greg Kroah-Hartman committed Sep 17, 2012
1 parent 6bc42c2 commit 604d66c
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/staging/comedi/drivers/ni_670x.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ static int __devinit ni_670x_attach_pci(struct comedi_device *dev,
return ret;
}
dev->board_name = thisboard->name;
dev->irq = mite_irq(devpriv->mite);

ret = comedi_alloc_subdevices(dev, 2);
if (ret)
Expand Down Expand Up @@ -293,8 +292,6 @@ static void ni_670x_detach(struct comedi_device *dev)
mite_unsetup(devpriv->mite);
mite_free(devpriv->mite);
}
if (dev->irq)
free_irq(dev->irq, dev);
}

static struct comedi_driver ni_670x_driver = {
Expand Down

0 comments on commit 604d66c

Please sign in to comment.