Skip to content

Commit

Permalink
perf newt: Make <- exit the ui_browser
Browse files Browse the repository at this point in the history
Right now that means that pressing the left arrow willl make the symbol
annotation window to exit back to the main symbol histogram browser.

This is another improvement on the UI fastpath, i.e. just the arrows and
enter are enough for most browsing.

Suggested-by: Ingo Molnar <mingo@elte.hu>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed May 15, 2010
1 parent 7ebaa28 commit 6055390
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tools/perf/util/newt.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ static int ui_browser__run(struct ui_browser *self, const char *title,
newtFormAddHotKey(self->form, NEWT_KEY_PGDN);
newtFormAddHotKey(self->form, NEWT_KEY_HOME);
newtFormAddHotKey(self->form, NEWT_KEY_END);
newtFormAddHotKey(self->form, NEWT_KEY_LEFT);

if (ui_browser__refresh_entries(self) < 0)
return -1;
Expand Down Expand Up @@ -408,6 +409,7 @@ static int ui_browser__run(struct ui_browser *self, const char *title,
}
break;
case NEWT_KEY_ESCAPE:
case NEWT_KEY_LEFT:
case CTRL('c'):
case 'Q':
case 'q':
Expand Down Expand Up @@ -616,7 +618,7 @@ static void hist_entry__annotate_browser(struct hist_entry *self)
if (hist_entry__annotate(self, &head) < 0)
return;

ui_helpline__push("Press ESC to exit");
ui_helpline__push("Press <- or ESC to exit");

memset(&browser, 0, sizeof(browser));
browser.entries = &head;
Expand Down

0 comments on commit 6055390

Please sign in to comment.