Skip to content

Commit

Permalink
ARM: 6949/2: mach-u300: fix compilaton warning in IO accessors
Browse files Browse the repository at this point in the history
The IO accessors for U300 were using u32 rather than the nominal
void __iomem * type, rectify this by properly defining the
virtual base for statically mapped peripherals to be
void __iomem *. Requires fixing a field in struct clk as well.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Linus Walleij authored and Russell King committed Jun 9, 2011
1 parent a0a54d3 commit 6075e9d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion arch/arm/mach-u300/clock.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ struct clk {
bool reset;
__u16 clk_val;
__s8 usecount;
__u32 res_reg;
void __iomem * res_reg;
__u16 res_mask;

bool hw_ctrld;
Expand Down
22 changes: 10 additions & 12 deletions arch/arm/mach-u300/include/mach/u300-regs.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@
* the defines are used for setting up the I/O memory mapping.
*/

#ifdef __ASSEMBLER__
#define IOMEM(a) (a)
#else
#define IOMEM(a) (void __iomem *) a
#endif

/* NAND Flash CS0 */
#define U300_NAND_CS0_PHYS_BASE 0x80000000

Expand Down Expand Up @@ -47,13 +53,6 @@
#define U300_SEMI_CONFIG_BASE 0x30000000
#endif

/*
* All the following peripherals are specified at their PHYSICAL address,
* so if you need to access them (in the kernel), you MUST use the macros
* defined in <asm/io.h> to map to the IO_ADDRESS_AHB() IO_ADDRESS_FAST()
* etc.
*/

/*
* AHB peripherals
*/
Expand All @@ -63,11 +62,11 @@

/* Vectored Interrupt Controller 0, servicing 32 interrupts */
#define U300_INTCON0_BASE (U300_AHB_PER_PHYS_BASE+0x1000)
#define U300_INTCON0_VBASE (U300_AHB_PER_VIRT_BASE+0x1000)
#define U300_INTCON0_VBASE IOMEM(U300_AHB_PER_VIRT_BASE+0x1000)

/* Vectored Interrupt Controller 1, servicing 32 interrupts */
#define U300_INTCON1_BASE (U300_AHB_PER_PHYS_BASE+0x2000)
#define U300_INTCON1_VBASE (U300_AHB_PER_VIRT_BASE+0x2000)
#define U300_INTCON1_VBASE IOMEM(U300_AHB_PER_VIRT_BASE+0x2000)

/* Memory Stick Pro (MSPRO) controller */
#define U300_MSPRO_BASE (U300_AHB_PER_PHYS_BASE+0x3000)
Expand Down Expand Up @@ -115,7 +114,7 @@

/* SYSCON */
#define U300_SYSCON_BASE (U300_SLOW_PER_PHYS_BASE+0x1000)
#define U300_SYSCON_VBASE (U300_SLOW_PER_VIRT_BASE+0x1000)
#define U300_SYSCON_VBASE IOMEM(U300_SLOW_PER_VIRT_BASE+0x1000)

/* Watchdog */
#define U300_WDOG_BASE (U300_SLOW_PER_PHYS_BASE+0x2000)
Expand All @@ -125,7 +124,7 @@

/* APP side special timer */
#define U300_TIMER_APP_BASE (U300_SLOW_PER_PHYS_BASE+0x4000)
#define U300_TIMER_APP_VBASE (U300_SLOW_PER_VIRT_BASE+0x4000)
#define U300_TIMER_APP_VBASE IOMEM(U300_SLOW_PER_VIRT_BASE+0x4000)

/* Keypad */
#define U300_KEYPAD_BASE (U300_SLOW_PER_PHYS_BASE+0x5000)
Expand Down Expand Up @@ -181,5 +180,4 @@
* Virtual accessor macros for static devices
*/


#endif

0 comments on commit 6075e9d

Please sign in to comment.