Skip to content

Commit

Permalink
phonedev: remove BKL
Browse files Browse the repository at this point in the history
The phone_device array is covered by the phone_lock mutex in all cases and
request_module no longer needs the BKL so we can remove the only remaining
instance of the BKL from phonedev.

Signed-off-by: Richard Holden <aciddeath@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Richard Holden authored and Linus Torvalds committed Oct 20, 2008
1 parent 3e680aa commit 60c11d2
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/telephony/phonedev.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ static int phone_open(struct inode *inode, struct file *file)
if (minor >= PHONE_NUM_DEVICES)
return -ENODEV;

lock_kernel();
mutex_lock(&phone_lock);
p = phone_device[minor];
if (p)
Expand All @@ -81,7 +80,6 @@ static int phone_open(struct inode *inode, struct file *file)
fops_put(old_fops);
end:
mutex_unlock(&phone_lock);
unlock_kernel();
return err;
}

Expand Down

0 comments on commit 60c11d2

Please sign in to comment.