Skip to content

Commit

Permalink
staging: comedi: amplc_dio200: use comedi_legacy_detach()
Browse files Browse the repository at this point in the history
The I/O region used by this driver is always requested using
comedi_request_region(). The devpriv->io union is only used by
the common code shared by the legacy and PCI drivers.

Use the new comedi_legacy_detach() helper in the (*detach) to
release the I/O region requested by this driver. That function
will handle the proper sanity checking before releasing the
resource.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Apr 19, 2013
1 parent 2120851 commit 60cb3b0
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions drivers/staging/comedi/drivers/amplc_dio200.c
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,8 @@ static int dio200_attach(struct comedi_device *dev, struct comedi_devconfig *it)

static void dio200_detach(struct comedi_device *dev)
{
const struct dio200_board *thisboard = comedi_board(dev);
struct dio200_private *devpriv = dev->private;

if (!thisboard || !devpriv)
return;
amplc_dio200_common_detach(dev);
if (devpriv->io.regtype == io_regtype)
release_region(devpriv->io.u.iobase, thisboard->mainsize);
comedi_legacy_detach(dev);
}

static struct comedi_driver amplc_dio200_driver = {
Expand Down

0 comments on commit 60cb3b0

Please sign in to comment.