Skip to content

Commit

Permalink
Merge tag 'omap-for-v3.11/pm-serial-signed' of git://git.kernel.org/p…
Browse files Browse the repository at this point in the history
…ub/scm/linux/kernel/git/tmlind/linux-omap into next/cleanup

From Tony Lindgren:

Serial driver platform init code clean-up via Kevin Hilman <khilman@linaro.org>:

OMAP: PM: the serial core + driver can no handle no_console_suspend support
without any SoC specific handlding or SoC-specific DT bindings.  Remove
the now unused SoC specifics for OMAP.

* tag 'omap-for-v3.11/pm-serial-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap:
  arm: omap2+: omap_device: remove no_idle_on_suspend
  arm: dts: am33xx: Remove "ti,no_idle_on_suspend" property.
  arm: omap2+: serial: remove no_console_suspend support

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
  • Loading branch information
Arnd Bergmann committed Jun 20, 2013
2 parents 412bb1c + 1e383d7 commit 60d808d
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 25 deletions.
1 change: 0 additions & 1 deletion arch/arm/boot/dts/am33xx.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@
compatible = "ti,am3352-ocmcram";
reg = <0x40300000 0x10000>;
ti,hwmods = "ocmcram";
ti,no_idle_on_suspend;
};

wkup_m3: wkup_m3@44d00000 {
Expand Down
9 changes: 2 additions & 7 deletions arch/arm/mach-omap2/omap_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,6 @@ static int omap_device_build_from_dt(struct platform_device *pdev)
r->name = dev_name(&pdev->dev);
}

if (of_get_property(node, "ti,no_idle_on_suspend", NULL))
omap_device_disable_idle_on_suspend(pdev);

pdev->dev.pm_domain = &omap_device_pm_domain;

odbfd_exit1:
Expand Down Expand Up @@ -621,8 +618,7 @@ static int _od_suspend_noirq(struct device *dev)

if (!ret && !pm_runtime_status_suspended(dev)) {
if (pm_generic_runtime_suspend(dev) == 0) {
if (!(od->flags & OMAP_DEVICE_NO_IDLE_ON_SUSPEND))
omap_device_idle(pdev);
omap_device_idle(pdev);
od->flags |= OMAP_DEVICE_SUSPENDED;
}
}
Expand All @@ -638,8 +634,7 @@ static int _od_resume_noirq(struct device *dev)
if ((od->flags & OMAP_DEVICE_SUSPENDED) &&
!pm_runtime_status_suspended(dev)) {
od->flags &= ~OMAP_DEVICE_SUSPENDED;
if (!(od->flags & OMAP_DEVICE_NO_IDLE_ON_SUSPEND))
omap_device_enable(pdev);
omap_device_enable(pdev);
pm_generic_runtime_resume(dev);
}

Expand Down
10 changes: 0 additions & 10 deletions arch/arm/mach-omap2/omap_device.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ extern struct dev_pm_domain omap_device_pm_domain;

/* omap_device.flags values */
#define OMAP_DEVICE_SUSPENDED BIT(0)
#define OMAP_DEVICE_NO_IDLE_ON_SUSPEND BIT(1)

/**
* struct omap_device - omap_device wrapper for platform_devices
Expand Down Expand Up @@ -101,13 +100,4 @@ static inline struct omap_device *to_omap_device(struct platform_device *pdev)
{
return pdev ? pdev->archdata.od : NULL;
}

static inline
void omap_device_disable_idle_on_suspend(struct platform_device *pdev)
{
struct omap_device *od = to_omap_device(pdev);

od->flags |= OMAP_DEVICE_NO_IDLE_ON_SUSPEND;
}

#endif
7 changes: 0 additions & 7 deletions arch/arm/mach-omap2/serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ struct omap_uart_state {
static LIST_HEAD(uart_list);
static u8 num_uarts;
static u8 console_uart_id = -1;
static u8 no_console_suspend;
static u8 uart_debug;

#define DEFAULT_RXDMA_POLLRATE 1 /* RX DMA polling rate (us) */
Expand Down Expand Up @@ -207,9 +206,6 @@ static int __init omap_serial_early_init(void)
uart_name, uart->num);
}

if (cmdline_find_option("no_console_suspend"))
no_console_suspend = true;

/*
* omap-uart can be used for earlyprintk logs
* So if omap-uart is used as console then prevent
Expand Down Expand Up @@ -292,9 +288,6 @@ void __init omap_serial_init_port(struct omap_board_data *bdata,
return;
}

if ((console_uart_id == bdata->id) && no_console_suspend)
omap_device_disable_idle_on_suspend(pdev);

oh->mux = omap_hwmod_mux_init(bdata->pads, bdata->pads_cnt);

if (console_uart_id == bdata->id) {
Expand Down

0 comments on commit 60d808d

Please sign in to comment.