Skip to content

Commit

Permalink
perf tools: Fix intlist node removal
Browse files Browse the repository at this point in the history
Similar to the one in :
	https://lkml.org/lkml/2012/8/29/27

Make sure we remove the node from the rblist before we delete the node.
The rblist__remove_node() will invoke rblist->node_delete, which  will
take care of deleting the node with the suitable function provided by
the user.

Signed-off-by: Suzuki K Poulose <suzuki@in.ibm.com>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Suzuki K Poulose <suzuki@in.ibm.com>
Link: http://lkml.kernel.org/r/20120831065840.5167.90318.stgit@suzukikp.in.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Suzuki K. Poulose authored and Arnaldo Carvalho de Melo committed Sep 5, 2012
1 parent 09a2f16 commit 60ebf32
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/perf/util/intlist.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ int intlist__add(struct intlist *ilist, int i)
return rblist__add_node(&ilist->rblist, (void *)((long)i));
}

void intlist__remove(struct intlist *ilist __used, struct int_node *node)
void intlist__remove(struct intlist *ilist, struct int_node *node)
{
int_node__delete(node);
rblist__remove_node(&ilist->rblist, &node->rb_node);
}

struct int_node *intlist__find(struct intlist *ilist, int i)
Expand Down

0 comments on commit 60ebf32

Please sign in to comment.