Skip to content

Commit

Permalink
Kobject: change drivers/base/sys.c to use kobject_init_and_add
Browse files Browse the repository at this point in the history
Stop using kobject_register, as this way we can control the sending of
the uevent properly, after everything is properly initialized.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jan 25, 2008
1 parent 64dbcac commit 61030bf
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions drivers/base/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,20 +224,15 @@ int sysdev_register(struct sys_device * sysdev)
if (!cls)
return -EINVAL;

pr_debug("Registering sys device '%s'\n", kobject_name(&sysdev->kobj));

/* Make sure the kset is set */
sysdev->kobj.kset = &cls->kset;

/* But make sure we point to the right type for sysfs translation */
sysdev->kobj.ktype = &ktype_sysdev;
error = kobject_set_name(&sysdev->kobj, "%s%d",
kobject_name(&cls->kset.kobj), sysdev->id);
if (error)
return error;

pr_debug("Registering sys device '%s'\n", kobject_name(&sysdev->kobj));

/* Register the object */
error = kobject_register(&sysdev->kobj);
error = kobject_init_and_add(&sysdev->kobj, &ktype_sysdev, NULL,
"%s%d", kobject_name(&cls->kset.kobj),
sysdev->id);

if (!error) {
struct sysdev_driver * drv;
Expand All @@ -254,6 +249,7 @@ int sysdev_register(struct sys_device * sysdev)
}
mutex_unlock(&sysdev_drivers_lock);
}
kobject_uevent(&sysdev->kobj, KOBJ_ADD);
return error;
}

Expand Down

0 comments on commit 61030bf

Please sign in to comment.