Skip to content

Commit

Permalink
[KEY]: Clean up proc files creation a bit.
Browse files Browse the repository at this point in the history
Mainly this removes ifdef-s from inside the ipsec_pfkey_init.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Pavel Emelyanov authored and David S. Miller committed Feb 10, 2008
1 parent 0efeaa3 commit 61145aa
Showing 1 changed file with 27 additions and 8 deletions.
35 changes: 27 additions & 8 deletions net/key/af_key.c
Original file line number Diff line number Diff line change
Expand Up @@ -3782,6 +3782,29 @@ static int pfkey_read_proc(char *buffer, char **start, off_t offset,

return len;
}

static int pfkey_init_proc(void)
{
if (create_proc_read_entry("pfkey", 0, init_net.proc_net,
pfkey_read_proc, NULL) == NULL)
return -ENOMEM;
else
return 0;
}

static void pfkey_exit_proc(void)
{
remove_proc_entry("net/pfkey", NULL);
}
#else
static inline int pfkey_init_proc(void)
{
return 0;
}

static inline void pfkey_exit_proc(void)
{
}
#endif

static struct xfrm_mgr pfkeyv2_mgr =
Expand All @@ -3798,7 +3821,7 @@ static struct xfrm_mgr pfkeyv2_mgr =
static void __exit ipsec_pfkey_exit(void)
{
xfrm_unregister_km(&pfkeyv2_mgr);
remove_proc_entry("pfkey", init_net.proc_net);
pfkey_exit_proc();
sock_unregister(PF_KEY);
proto_unregister(&key_proto);
}
Expand All @@ -3813,21 +3836,17 @@ static int __init ipsec_pfkey_init(void)
err = sock_register(&pfkey_family_ops);
if (err != 0)
goto out_unregister_key_proto;
#ifdef CONFIG_PROC_FS
err = -ENOMEM;
if (create_proc_read_entry("pfkey", 0, init_net.proc_net, pfkey_read_proc, NULL) == NULL)
err = pfkey_init_proc();
if (err != 0)
goto out_sock_unregister;
#endif
err = xfrm_register_km(&pfkeyv2_mgr);
if (err != 0)
goto out_remove_proc_entry;
out:
return err;
out_remove_proc_entry:
#ifdef CONFIG_PROC_FS
remove_proc_entry("net/pfkey", NULL);
pfkey_exit_proc();
out_sock_unregister:
#endif
sock_unregister(PF_KEY);
out_unregister_key_proto:
proto_unregister(&key_proto);
Expand Down

0 comments on commit 61145aa

Please sign in to comment.