Skip to content

Commit

Permalink
powerpc: fsl_msi doesn't need it's own of_node
Browse files Browse the repository at this point in the history
The FSL MSI code keeps a pointer to the of_node from the device
it represents.  However it also has an irq_host, which contains
a pointer to the of_node, so use that one instead.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Michael Ellerman authored and Paul Mackerras committed Aug 20, 2008
1 parent dcfcfe7 commit 611cd90
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
12 changes: 5 additions & 7 deletions arch/powerpc/sysdev/fsl_msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ static int fsl_msi_free_dt_hwirqs(struct fsl_msi *msi)
bitmap_allocate_region(msi->fsl_msi_bitmap, 0,
get_count_order(NR_MSI_IRQS));

p = of_get_property(msi->of_node, "msi-available-ranges", &len);
p = of_get_property(msi->irqhost->of_node, "msi-available-ranges",
&len);

if (!p) {
/* No msi-available-ranges property,
Expand All @@ -120,7 +121,7 @@ static int fsl_msi_free_dt_hwirqs(struct fsl_msi *msi)

if ((len % (2 * sizeof(u32))) != 0) {
printk(KERN_WARNING "fsl_msi: Malformed msi-available-ranges "
"property on %s\n", msi->of_node->full_name);
"property on %s\n", msi->irqhost->of_node->full_name);
return -EINVAL;
}

Expand Down Expand Up @@ -317,14 +318,11 @@ static int __devinit fsl_of_msi_probe(struct of_device *dev,
goto error_out;
}

msi->of_node = of_node_get(dev->node);
msi->irqhost = irq_alloc_host(dev->node, IRQ_HOST_MAP_LINEAR,
NR_MSI_IRQS, &fsl_msi_host_ops, 0);

msi->irqhost = irq_alloc_host(of_node_get(dev->node),
IRQ_HOST_MAP_LINEAR,
NR_MSI_IRQS, &fsl_msi_host_ops, 0);
if (msi->irqhost == NULL) {
dev_err(&dev->dev, "No memory for MSI irqhost\n");
of_node_put(dev->node);
err = -ENOMEM;
goto error_out;
}
Expand Down
3 changes: 0 additions & 3 deletions arch/powerpc/sysdev/fsl_msi.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@
#define FSL_PIC_IP_IPIC 0x00000002

struct fsl_msi {
/* Device node of the MSI interrupt*/
struct device_node *of_node;

struct irq_host *irqhost;

unsigned long cascade_irq;
Expand Down

0 comments on commit 611cd90

Please sign in to comment.