Skip to content

Commit

Permalink
[ACPI] delete CONFIG_ACPI_PCI
Browse files Browse the repository at this point in the history
Delete the ability to build an ACPI kernel that does
not include PCI support.  When such a machine is created
and it requires a tuned kernel, send a patch.

http://bugzilla.kernel.org/show_bug.cgi?id=1364

Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Len Brown committed Aug 25, 2005
1 parent 07fefe4 commit 6153df7
Show file tree
Hide file tree
Showing 19 changed files with 28 additions and 84 deletions.
1 change: 0 additions & 1 deletion arch/i386/defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ CONFIG_ACPI_THERMAL=y
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y
# CONFIG_X86_PM_TIMER is not set

Expand Down
9 changes: 0 additions & 9 deletions arch/i386/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,8 @@ static inline int ioapic_setup_disabled(void)

#define PREFIX "ACPI: "

#ifdef CONFIG_ACPI_PCI
int acpi_noirq __initdata; /* skip ACPI IRQ initialization */
int acpi_pci_disabled __initdata; /* skip ACPI PCI scan and IRQ initialization */
#else
int acpi_noirq __initdata = 1;
int acpi_pci_disabled __initdata = 1;
#endif
int acpi_ht __initdata = 1; /* enable HT */

int acpi_lapic;
Expand Down Expand Up @@ -849,7 +844,6 @@ extern int acpi_force;

#ifdef __i386__

#ifdef CONFIG_ACPI_PCI
static int __init disable_acpi_irq(struct dmi_system_id *d)
{
if (!acpi_force) {
Expand All @@ -869,7 +863,6 @@ static int __init disable_acpi_pci(struct dmi_system_id *d)
}
return 0;
}
#endif

static int __init dmi_disable_acpi(struct dmi_system_id *d)
{
Expand Down Expand Up @@ -1017,7 +1010,6 @@ static struct dmi_system_id __initdata acpi_dmi_table[] = {
},
},

#ifdef CONFIG_ACPI_PCI
/*
* Boxes that need ACPI PCI IRQ routing disabled
*/
Expand Down Expand Up @@ -1055,7 +1047,6 @@ static struct dmi_system_id __initdata acpi_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
},
},
#endif
{}
};

Expand Down
2 changes: 1 addition & 1 deletion arch/i386/pci/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ obj-$(CONFIG_PCI_MMCONFIG) += mmconfig.o
obj-$(CONFIG_PCI_DIRECT) += direct.o

pci-y := fixup.o
pci-$(CONFIG_ACPI_PCI) += acpi.o
pci-$(CONFIG_ACPI) += acpi.o
pci-y += legacy.o irq.o

pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
Expand Down
2 changes: 1 addition & 1 deletion arch/i386/pci/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ static void pirq_penalize_isa_irq(int irq, int active)

void pcibios_penalize_isa_irq(int irq, int active)
{
#ifdef CONFIG_ACPI_PCI
#ifdef CONFIG_ACPI
if (!acpi_noirq)
acpi_penalize_isa_irq(irq, active);
else
Expand Down
1 change: 0 additions & 1 deletion arch/ia64/configs/bigsur_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ CONFIG_ACPI_PROCESSOR=m
CONFIG_ACPI_THERMAL=m
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y

#
Expand Down
1 change: 0 additions & 1 deletion arch/ia64/configs/sn2_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ CONFIG_ACPI=y
CONFIG_ACPI_NUMA=y
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y
# CONFIG_ACPI_CONTAINER is not set

Expand Down
1 change: 0 additions & 1 deletion arch/ia64/configs/tiger_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ CONFIG_ACPI_PROCESSOR=m
CONFIG_ACPI_THERMAL=m
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y
# CONFIG_ACPI_CONTAINER is not set

Expand Down
1 change: 0 additions & 1 deletion arch/ia64/configs/zx1_defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ CONFIG_ACPI_PROCESSOR=y
CONFIG_ACPI_THERMAL=y
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y
# CONFIG_ACPI_CONTAINER is not set

Expand Down
1 change: 0 additions & 1 deletion arch/ia64/defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ CONFIG_ACPI_THERMAL=m
CONFIG_ACPI_NUMA=y
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y
CONFIG_ACPI_CONTAINER=m

Expand Down
1 change: 0 additions & 1 deletion arch/x86_64/defconfig
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ CONFIG_ACPI_BLACKLIST_YEAR=2001
# CONFIG_ACPI_DEBUG is not set
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_PCI=y
CONFIG_ACPI_SYSTEM=y
# CONFIG_ACPI_CONTAINER is not set

Expand Down
2 changes: 1 addition & 1 deletion arch/x86_64/pci/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ CFLAGS += -Iarch/i386/pci
obj-y := i386.o
obj-$(CONFIG_PCI_DIRECT)+= direct.o
obj-y += fixup.o
obj-$(CONFIG_ACPI_PCI) += acpi.o
obj-$(CONFIG_ACPI) += acpi.o
obj-y += legacy.o irq.o common.o
# mmconfig has a 64bit special
obj-$(CONFIG_PCI_MMCONFIG) += mmconfig.o
Expand Down
2 changes: 1 addition & 1 deletion arch/x86_64/pci/Makefile-BUS
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ CFLAGS += -I arch/i386/pci
obj-y := i386.o
obj-$(CONFIG_PCI_DIRECT)+= direct.o
obj-y += fixup.o
obj-$(CONFIG_ACPI_PCI) += acpi.o
obj-$(CONFIG_ACPI) += acpi.o
obj-y += legacy.o irq.o common.o
# mmconfig has a 64bit special
obj-$(CONFIG_PCI_MMCONFIG) += mmconfig.o
Expand Down
7 changes: 2 additions & 5 deletions drivers/acpi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,15 @@
#

menu "ACPI (Advanced Configuration and Power Interface) Support"
depends on PM
depends on !X86_VISWS
depends on !IA64_HP_SIM
depends on IA64 || X86

config ACPI
bool "ACPI Support"
depends on IA64 || X86
select PM
select PCI

default y
---help---
Expand Down Expand Up @@ -281,10 +282,6 @@ config ACPI_POWER
bool
default y

config ACPI_PCI
bool
default PCI

config ACPI_SYSTEM
bool
default y
Expand Down
2 changes: 1 addition & 1 deletion drivers/acpi/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ obj-$(CONFIG_ACPI_EC) += ec.o
obj-$(CONFIG_ACPI_FAN) += fan.o
obj-$(CONFIG_ACPI_VIDEO) += video.o
obj-$(CONFIG_ACPI_HOTKEY) += hotkey.o
obj-$(CONFIG_ACPI_PCI) += pci_root.o pci_link.o pci_irq.o pci_bind.o
obj-y += pci_root.o pci_link.o pci_irq.o pci_bind.o
obj-$(CONFIG_ACPI_POWER) += power.o
obj-$(CONFIG_ACPI_PROCESSOR) += processor.o
obj-$(CONFIG_ACPI_CONTAINER) += container.o
Expand Down
28 changes: 0 additions & 28 deletions drivers/acpi/osl.c
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,11 @@ acpi_status acpi_os_initialize1(void)
* Initialize PCI configuration space access, as we'll need to access
* it while walking the namespace (bus 0 and root bridges w/ _BBNs).
*/
#ifdef CONFIG_ACPI_PCI
if (!raw_pci_ops) {
printk(KERN_ERR PREFIX
"Access to PCI configuration space unavailable\n");
return AE_NULL_ENTRY;
}
#endif
kacpid_wq = create_singlethread_workqueue("kacpid");
BUG_ON(!kacpid_wq);

Expand Down Expand Up @@ -484,8 +482,6 @@ acpi_os_write_memory(acpi_physical_address phys_addr, u32 value, u32 width)
return AE_OK;
}

#ifdef CONFIG_ACPI_PCI

acpi_status
acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id, u32 reg,
void *value, u32 width)
Expand Down Expand Up @@ -618,30 +614,6 @@ void acpi_os_derive_pci_id(acpi_handle rhandle, /* upper bound */
acpi_os_derive_pci_id_2(rhandle, chandle, id, &is_bridge, &bus_number);
}

#else /*!CONFIG_ACPI_PCI */

acpi_status
acpi_os_write_pci_configuration(struct acpi_pci_id * pci_id,
u32 reg, acpi_integer value, u32 width)
{
return AE_SUPPORT;
}

acpi_status
acpi_os_read_pci_configuration(struct acpi_pci_id * pci_id,
u32 reg, void *value, u32 width)
{
return AE_SUPPORT;
}

void acpi_os_derive_pci_id(acpi_handle rhandle, /* upper bound */
acpi_handle chandle, /* current node */
struct acpi_pci_id **id)
{
}

#endif /*CONFIG_ACPI_PCI */

static void acpi_os_execute_deferred(void *context)
{
struct acpi_os_dpc *dpc = NULL;
Expand Down
4 changes: 0 additions & 4 deletions include/acpi/acpi_drivers.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@
PCI
-------------------------------------------------------------------------- */

#ifdef CONFIG_ACPI_PCI

#define ACPI_PCI_COMPONENT 0x00400000

/* ACPI PCI Interrupt Link (pci_link.c) */
Expand Down Expand Up @@ -78,8 +76,6 @@ int acpi_pci_bind_root(struct acpi_device *device, struct acpi_pci_id *id,
struct pci_bus *pci_acpi_scan_root(struct acpi_device *device, int domain,
int bus);

#endif /*CONFIG_ACPI_PCI */

/* --------------------------------------------------------------------------
Power Resource
-------------------------------------------------------------------------- */
Expand Down
18 changes: 8 additions & 10 deletions include/asm-i386/acpi.h
Original file line number Diff line number Diff line change
Expand Up @@ -146,25 +146,23 @@ static inline void check_acpi_pci(void) { }

#endif

#else /* !CONFIG_ACPI */
# define acpi_lapic 0
# define acpi_ioapic 0

#endif

#ifdef CONFIG_ACPI_PCI
static inline void acpi_noirq_set(void) { acpi_noirq = 1; }
static inline void acpi_disable_pci(void)
{
acpi_pci_disabled = 1;
acpi_noirq_set();
}
extern int acpi_irq_balance_set(char *str);
#else

#else /* !CONFIG_ACPI */

#define acpi_lapic 0
#define acpi_ioapic 0
static inline void acpi_noirq_set(void) { }
static inline void acpi_disable_pci(void) { }
static inline int acpi_irq_balance_set(char *str) { return 0; }
#endif

#endif /* !CONFIG_ACPI */


#ifdef CONFIG_ACPI_SLEEP

Expand Down
25 changes: 11 additions & 14 deletions include/asm-x86_64/acpi.h
Original file line number Diff line number Diff line change
Expand Up @@ -121,29 +121,26 @@ static inline void disable_acpi(void)
#define FIX_ACPI_PAGES 4

extern int acpi_gsi_to_irq(u32 gsi, unsigned int *irq);

#else /* !CONFIG_ACPI */
#define acpi_lapic 0
#define acpi_ioapic 0
#endif /* !CONFIG_ACPI */

extern int acpi_numa;
extern int acpi_scan_nodes(unsigned long start, unsigned long end);
#define NR_NODE_MEMBLKS (MAX_NUMNODES*2)

#ifdef CONFIG_ACPI_PCI
static inline void acpi_noirq_set(void) { acpi_noirq = 1; }
static inline void acpi_disable_pci(void)
{
acpi_pci_disabled = 1;
acpi_noirq_set();
}
extern int acpi_irq_balance_set(char *str);
#else

#else /* !CONFIG_ACPI */

#define acpi_lapic 0
#define acpi_ioapic 0
static inline void acpi_noirq_set(void) { }
static inline void acpi_disable_pci(void) { }
static inline int acpi_irq_balance_set(char *str) { return 0; }
#endif

#endif /* !CONFIG_ACPI */

extern int acpi_numa;
extern int acpi_scan_nodes(unsigned long start, unsigned long end);
#define NR_NODE_MEMBLKS (MAX_NUMNODES*2)

#ifdef CONFIG_ACPI_SLEEP

Expand Down
4 changes: 2 additions & 2 deletions include/linux/acpi.h
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ int acpi_gsi_to_irq (u32 gsi, unsigned int *irq);
*/
void acpi_unregister_gsi (u32 gsi);

#ifdef CONFIG_ACPI_PCI
#ifdef CONFIG_ACPI

struct acpi_prt_entry {
struct list_head node;
Expand Down Expand Up @@ -479,7 +479,7 @@ struct acpi_pci_driver {
int acpi_pci_register_driver(struct acpi_pci_driver *driver);
void acpi_pci_unregister_driver(struct acpi_pci_driver *driver);

#endif /*CONFIG_ACPI_PCI*/
#endif /* CONFIG_ACPI */

#ifdef CONFIG_ACPI_EC

Expand Down

0 comments on commit 6153df7

Please sign in to comment.