Skip to content

Commit

Permalink
[ALSA] usb-audio - rename QUIRK_MIDI_MOTU to QUIRK_MIDI_RAW
Browse files Browse the repository at this point in the history
USB generic driver
Rename the protocol used by the MOTU FastLane to 'raw' because it might
be useful with other devices, and there are other MOTU interfaces that
do not use this protocol.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
  • Loading branch information
Clemens Ladisch authored and Jaroslav Kysela committed Jul 28, 2005
1 parent b1c6ef5 commit 6155aff
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion sound/usb/usbaudio.c
Original file line number Diff line number Diff line change
Expand Up @@ -2970,7 +2970,7 @@ static int snd_usb_create_quirk(snd_usb_audio_t *chip,
case QUIRK_MIDI_YAMAHA:
case QUIRK_MIDI_MIDIMAN:
case QUIRK_MIDI_NOVATION:
case QUIRK_MIDI_MOTU:
case QUIRK_MIDI_RAW:
case QUIRK_MIDI_EMAGIC:
return snd_usb_create_midi_interface(chip, iface, quirk);
case QUIRK_COMPOSITE:
Expand Down
4 changes: 2 additions & 2 deletions sound/usb/usbaudio.h
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ struct snd_usb_audio {
#define QUIRK_AUDIO_EDIROL_UA1000 8
#define QUIRK_IGNORE_INTERFACE 9
#define QUIRK_MIDI_NOVATION 10
#define QUIRK_MIDI_MOTU 11
#define QUIRK_MIDI_RAW 11
#define QUIRK_MIDI_EMAGIC 12

typedef struct snd_usb_audio_quirk snd_usb_audio_quirk_t;
Expand Down Expand Up @@ -205,7 +205,7 @@ struct snd_usb_midi_endpoint_info {

/* for QUIRK_IGNORE_INTERFACE, data is NULL */

/* for QUIRK_MIDI_NOVATION and _MOTU, data is NULL */
/* for QUIRK_MIDI_NOVATION and _RAW, data is NULL */

/* for QUIRK_MIDI_EMAGIC, data points to a snd_usb_midi_endpoint_info
* structure (out_cables and in_cables only) */
Expand Down
18 changes: 9 additions & 9 deletions sound/usb/usbmidi.c
Original file line number Diff line number Diff line change
Expand Up @@ -524,16 +524,16 @@ static struct usb_protocol_ops snd_usbmidi_novation_ops = {
};

/*
* Mark of the Unicorn USB MIDI protocol: raw MIDI.
* "raw" protocol: used by the MOTU FastLane.
*/

static void snd_usbmidi_motu_input(snd_usb_midi_in_endpoint_t* ep,
uint8_t* buffer, int buffer_length)
static void snd_usbmidi_raw_input(snd_usb_midi_in_endpoint_t* ep,
uint8_t* buffer, int buffer_length)
{
snd_usbmidi_input_data(ep, 0, buffer, buffer_length);
}

static void snd_usbmidi_motu_output(snd_usb_midi_out_endpoint_t* ep)
static void snd_usbmidi_raw_output(snd_usb_midi_out_endpoint_t* ep)
{
int count;

Expand All @@ -549,9 +549,9 @@ static void snd_usbmidi_motu_output(snd_usb_midi_out_endpoint_t* ep)
ep->urb->transfer_buffer_length = count;
}

static struct usb_protocol_ops snd_usbmidi_motu_ops = {
.input = snd_usbmidi_motu_input,
.output = snd_usbmidi_motu_output,
static struct usb_protocol_ops snd_usbmidi_raw_ops = {
.input = snd_usbmidi_raw_input,
.output = snd_usbmidi_raw_output,
};

/*
Expand Down Expand Up @@ -1505,8 +1505,8 @@ int snd_usb_create_midi_interface(snd_usb_audio_t* chip,
umidi->usb_protocol_ops = &snd_usbmidi_novation_ops;
err = snd_usbmidi_detect_per_port_endpoints(umidi, endpoints);
break;
case QUIRK_MIDI_MOTU:
umidi->usb_protocol_ops = &snd_usbmidi_motu_ops;
case QUIRK_MIDI_RAW:
umidi->usb_protocol_ops = &snd_usbmidi_raw_ops;
err = snd_usbmidi_detect_per_port_endpoints(umidi, endpoints);
break;
case QUIRK_MIDI_EMAGIC:
Expand Down
2 changes: 1 addition & 1 deletion sound/usb/usbquirks.h
Original file line number Diff line number Diff line change
Expand Up @@ -1269,7 +1269,7 @@ YAMAHA_DEVICE(0x7010, "UB99"),
.data = & (const snd_usb_audio_quirk_t[]) {
{
.ifnum = 0,
.type = QUIRK_MIDI_MOTU
.type = QUIRK_MIDI_RAW
},
{
.ifnum = 1,
Expand Down

0 comments on commit 6155aff

Please sign in to comment.