Skip to content

Commit

Permalink
[PATCH] ieee1394: remove NULL checks for kfree
Browse files Browse the repository at this point in the history
This patch removes redundant NULL pointer checks before kfree() in all of
drivers/ieee1394/

Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: Jody McIntyre <scjody@steamballoon.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jody McIntyre authored and Linus Torvalds committed May 17, 2005
1 parent 9ac485d commit 616b859
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 24 deletions.
3 changes: 1 addition & 2 deletions drivers/ieee1394/nodemgr.c
Original file line number Diff line number Diff line change
Expand Up @@ -1005,8 +1005,7 @@ static struct unit_directory *nodemgr_process_unit_directory
return ud;

unit_directory_error:
if (ud != NULL)
kfree(ud);
kfree(ud);
return NULL;
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/ieee1394/ohci1394.c
Original file line number Diff line number Diff line change
Expand Up @@ -2931,7 +2931,7 @@ static void free_dma_rcv_ctx(struct dma_rcv_ctx *d)
kfree(d->prg_cpu);
kfree(d->prg_bus);
}
if (d->spb) kfree(d->spb);
kfree(d->spb);

/* Mark this context as freed. */
d->ohci = NULL;
Expand Down
29 changes: 8 additions & 21 deletions drivers/ieee1394/video1394.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,23 +180,13 @@ static int free_dma_iso_ctx(struct dma_iso_ctx *d)
kfree(d->prg_reg);
}

if (d->ir_prg)
kfree(d->ir_prg);

if (d->it_prg)
kfree(d->it_prg);

if (d->buffer_status)
kfree(d->buffer_status);
if (d->buffer_time)
kfree(d->buffer_time);
if (d->last_used_cmd)
kfree(d->last_used_cmd);
if (d->next_buffer)
kfree(d->next_buffer);

kfree(d->ir_prg);
kfree(d->it_prg);
kfree(d->buffer_status);
kfree(d->buffer_time);
kfree(d->last_used_cmd);
kfree(d->next_buffer);
list_del(&d->link);

kfree(d);

return 0;
Expand Down Expand Up @@ -1060,8 +1050,7 @@ static int __video1394_ioctl(struct file *file,
PRINT(KERN_ERR, ohci->host->id,
"Buffer %d is already used",v.buffer);
spin_unlock_irqrestore(&d->lock,flags);
if (psizes)
kfree(psizes);
kfree(psizes);
return -EBUSY;
}

Expand Down Expand Up @@ -1116,9 +1105,7 @@ static int __video1394_ioctl(struct file *file,
}
}

if (psizes)
kfree(psizes);

kfree(psizes);
return 0;

}
Expand Down

0 comments on commit 616b859

Please sign in to comment.