Skip to content

Commit

Permalink
ima: return d_name.name if d_path fails
Browse files Browse the repository at this point in the history
This is a small refactoring so ima_d_path() returns dentry name
if path reconstruction fails. It simplifies callers actions
and removes code duplication.

Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
  • Loading branch information
Dmitry Kasatkin authored and Mimi Zohar committed Mar 7, 2014
1 parent 2bb930a commit 61997c4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion security/integrity/ima/ima_api.c
Original file line number Diff line number Diff line change
Expand Up @@ -332,5 +332,5 @@ const char *ima_d_path(struct path *path, char **pathbuf)
pathname = NULL;
}
}
return pathname;
return pathname ?: (const char *)path->dentry->d_name.name;
}
7 changes: 1 addition & 6 deletions security/integrity/ima/ima_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ __setup("ima_hash=", hash_setup);
*/
static void ima_rdwr_violation_check(struct file *file)
{
struct dentry *dentry = file->f_path.dentry;
struct inode *inode = file_inode(file);
fmode_t mode = file->f_mode;
int must_measure;
Expand Down Expand Up @@ -111,8 +110,6 @@ static void ima_rdwr_violation_check(struct file *file)
return;

pathname = ima_d_path(&file->f_path, &pathbuf);
if (!pathname || strlen(pathname) > IMA_EVENT_NAME_LEN_MAX)
pathname = dentry->d_name.name;

if (send_tomtou)
ima_add_violation(file, pathname, "invalid_pcr", "ToMToU");
Expand Down Expand Up @@ -220,9 +217,7 @@ static int process_measurement(struct file *file, const char *filename,
if (rc != 0)
goto out_digsig;

pathname = !filename ? ima_d_path(&file->f_path, &pathbuf) : filename;
if (!pathname)
pathname = (const char *)file->f_dentry->d_name.name;
pathname = filename ?: ima_d_path(&file->f_path, &pathbuf);

if (action & IMA_MEASURE)
ima_store_measurement(iint, file, pathname,
Expand Down

0 comments on commit 61997c4

Please sign in to comment.