Skip to content

Commit

Permalink
ide: remove redundant DMA blacklist check from __ide_dma_on()
Browse files Browse the repository at this point in the history
->ide_dma_on method is called only after successful ide_dma_check() call
(ide_dma_check()->ide_tune_dma() checks DMA blacklist) or if drive->using_dma
has been previously enabled for a given device (->ide_dma_on is the only place
which sets drive->using_dma to '1').

There should be no functionality changes caused by this patch.

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Jan 25, 2008
1 parent 7b90599 commit 61a368c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/ide/ide-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -491,10 +491,6 @@ EXPORT_SYMBOL(ide_dma_host_on);

int __ide_dma_on (ide_drive_t *drive)
{
/* consult the list of known "bad" drives */
if (__ide_dma_bad_drive(drive))
return 1;

drive->using_dma = 1;
ide_toggle_bounce(drive, 1);

Expand Down

0 comments on commit 61a368c

Please sign in to comment.