Skip to content

Commit

Permalink
perf trace: Clean up find_debugfs()
Browse files Browse the repository at this point in the history
Remove redundant code for 'perf trace'

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Clark Williams <williams@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
LKML-Reference: <4B3870DE.7090500@cn.fujitsu.com>
[ v2: resolved conflicts with recent changes ]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Xiao Guangrong authored and Ingo Molnar committed Dec 28, 2009
1 parent 29c52aa commit 61be3e5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 24 deletions.
1 change: 1 addition & 0 deletions tools/perf/util/debugfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ char *debugfs_mount(const char *mountpoint)

/* save the mountpoint */
strncpy(debugfs_mountpoint, mountpoint, sizeof(debugfs_mountpoint));
debugfs_found = 1;

return debugfs_mountpoint;
}
Expand Down
29 changes: 5 additions & 24 deletions tools/perf/util/trace-event-info.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@

#include "../perf.h"
#include "trace-event.h"
#include "debugfs.h"

#define VERSION "0.5"

Expand Down Expand Up @@ -102,32 +103,12 @@ void *malloc_or_die(unsigned int size)

static const char *find_debugfs(void)
{
static char debugfs[MAX_PATH+1];
static int debugfs_found;
FILE *fp;
struct mntent *m;

if (debugfs_found)
return debugfs;

fp = setmntent("/proc/mounts", "r");
if (!fp)
die("Can't open /proc/mounts for read");

while ((m = getmntent(fp)) != NULL) {
if (strcmp(m->mnt_type, "debugfs") == 0) {
strcpy(debugfs, m->mnt_dir);
debugfs_found = 1;
break;
}
}

endmntent(fp);
const char *path = debugfs_mount(NULL);

if (!debugfs_found)
die("debugfs not mounted, please mount");
if (!path)
die("Your kernel not support debugfs filesystem");

return debugfs;
return path;
}

/*
Expand Down

0 comments on commit 61be3e5

Please sign in to comment.