Skip to content

Commit

Permalink
[media] BKL: trivial ioctl -> unlocked_ioctl video driver conversions
Browse files Browse the repository at this point in the history
These drivers could be trivially converted to unlocked_ioctl since they
already did locking.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Dec 1, 2010
1 parent d2c998f commit 61df3c9
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion drivers/media/video/arv.c
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ static int ar_initialize(struct ar *ar)
static const struct v4l2_file_operations ar_fops = {
.owner = THIS_MODULE,
.read = ar_read,
.ioctl = video_ioctl2,
.unlocked_ioctl = video_ioctl2,
};

static const struct v4l2_ioctl_ops ar_ioctl_ops = {
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/bw-qcam.c
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ static ssize_t qcam_read(struct file *file, char __user *buf,

static const struct v4l2_file_operations qcam_fops = {
.owner = THIS_MODULE,
.ioctl = video_ioctl2,
.unlocked_ioctl = video_ioctl2,
.read = qcam_read,
};

Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/c-qcam.c
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ static ssize_t qcam_read(struct file *file, char __user *buf,

static const struct v4l2_file_operations qcam_fops = {
.owner = THIS_MODULE,
.ioctl = video_ioctl2,
.unlocked_ioctl = video_ioctl2,
.read = qcam_read,
};

Expand Down
14 changes: 7 additions & 7 deletions drivers/media/video/meye.c
Original file line number Diff line number Diff line change
Expand Up @@ -1659,7 +1659,7 @@ static const struct v4l2_file_operations meye_fops = {
.open = meye_open,
.release = meye_release,
.mmap = meye_mmap,
.ioctl = video_ioctl2,
.unlocked_ioctl = video_ioctl2,
.poll = meye_poll,
};

Expand Down Expand Up @@ -1831,12 +1831,6 @@ static int __devinit meye_probe(struct pci_dev *pcidev,
msleep(1);
mchip_set(MCHIP_MM_INTA, MCHIP_MM_INTA_HIC_1_MASK);

if (video_register_device(meye.vdev, VFL_TYPE_GRABBER,
video_nr) < 0) {
v4l2_err(v4l2_dev, "video_register_device failed\n");
goto outvideoreg;
}

mutex_init(&meye.lock);
init_waitqueue_head(&meye.proc_list);
meye.brightness = 32 << 10;
Expand All @@ -1858,6 +1852,12 @@ static int __devinit meye_probe(struct pci_dev *pcidev,
sony_pic_camera_command(SONY_PIC_COMMAND_SETCAMERAPICTURE, 0);
sony_pic_camera_command(SONY_PIC_COMMAND_SETCAMERAAGC, 48);

if (video_register_device(meye.vdev, VFL_TYPE_GRABBER,
video_nr) < 0) {
v4l2_err(v4l2_dev, "video_register_device failed\n");
goto outvideoreg;
}

v4l2_info(v4l2_dev, "Motion Eye Camera Driver v%s.\n",
MEYE_DRIVER_VERSION);
v4l2_info(v4l2_dev, "mchip KL5A72002 rev. %d, base %lx, irq %d\n",
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/pms.c
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@ static ssize_t pms_read(struct file *file, char __user *buf,

static const struct v4l2_file_operations pms_fops = {
.owner = THIS_MODULE,
.ioctl = video_ioctl2,
.unlocked_ioctl = video_ioctl2,
.read = pms_read,
};

Expand Down
2 changes: 1 addition & 1 deletion drivers/media/video/w9966.c
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ static ssize_t w9966_v4l_read(struct file *file, char __user *buf,

static const struct v4l2_file_operations w9966_fops = {
.owner = THIS_MODULE,
.ioctl = video_ioctl2,
.unlocked_ioctl = video_ioctl2,
.read = w9966_v4l_read,
};

Expand Down

0 comments on commit 61df3c9

Please sign in to comment.