Skip to content

Commit

Permalink
airo_cs: Remove typedef local_info_t
Browse files Browse the repository at this point in the history
The Linux kernel coding style guidelines suggest not using typedefs
for structure types. This patch gets rid of the typedef for
local_info_t. Also, the name of the struct is changed to drop the _t,
to make the name look less typedef-like.

The following Coccinelle semantic patch detects the case:

@tn@
identifier i;
type td;
@@

-typedef
 struct i { ... }
-td
 ;

@@
type tn.td;
identifier tn.i;
@@

-td
+ struct i

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Himangi Saraogi authored and David S. Miller committed Aug 11, 2014
1 parent f0db82a commit 61ecba6
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions drivers/net/wireless/airo_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,18 @@ static void airo_release(struct pcmcia_device *link);

static void airo_detach(struct pcmcia_device *p_dev);

typedef struct local_info_t {
struct local_info {
struct net_device *eth_dev;
} local_info_t;
};

static int airo_probe(struct pcmcia_device *p_dev)
{
local_info_t *local;
struct local_info *local;

dev_dbg(&p_dev->dev, "airo_attach()\n");

/* Allocate space for private device-specific data */
local = kzalloc(sizeof(local_info_t), GFP_KERNEL);
local = kzalloc(sizeof(*local), GFP_KERNEL);
if (!local)
return -ENOMEM;

Expand All @@ -82,10 +82,11 @@ static void airo_detach(struct pcmcia_device *link)

airo_release(link);

if (((local_info_t *)link->priv)->eth_dev) {
stop_airo_card(((local_info_t *)link->priv)->eth_dev, 0);
if (((struct local_info *)link->priv)->eth_dev) {
stop_airo_card(((struct local_info *)link->priv)->eth_dev,
0);
}
((local_info_t *)link->priv)->eth_dev = NULL;
((struct local_info *)link->priv)->eth_dev = NULL;

kfree(link->priv);
} /* airo_detach */
Expand All @@ -101,7 +102,7 @@ static int airo_cs_config_check(struct pcmcia_device *p_dev, void *priv_data)

static int airo_config(struct pcmcia_device *link)
{
local_info_t *dev;
struct local_info *dev;
int ret;

dev = link->priv;
Expand All @@ -121,10 +122,10 @@ static int airo_config(struct pcmcia_device *link)
ret = pcmcia_enable_device(link);
if (ret)
goto failed;
((local_info_t *)link->priv)->eth_dev =
((struct local_info *)link->priv)->eth_dev =
init_airo_card(link->irq,
link->resource[0]->start, 1, &link->dev);
if (!((local_info_t *)link->priv)->eth_dev)
if (!((struct local_info *)link->priv)->eth_dev)
goto failed;

return 0;
Expand All @@ -142,7 +143,7 @@ static void airo_release(struct pcmcia_device *link)

static int airo_suspend(struct pcmcia_device *link)
{
local_info_t *local = link->priv;
struct local_info *local = link->priv;

netif_device_detach(local->eth_dev);

Expand All @@ -151,7 +152,7 @@ static int airo_suspend(struct pcmcia_device *link)

static int airo_resume(struct pcmcia_device *link)
{
local_info_t *local = link->priv;
struct local_info *local = link->priv;

if (link->open) {
reset_airo_card(local->eth_dev);
Expand Down

0 comments on commit 61ecba6

Please sign in to comment.