Skip to content

Commit

Permalink
[media] em28xx: simplify argument passing to em28xx_init_dev()
Browse files Browse the repository at this point in the history
The 'struct em28xx *' pointer was passed by reference to the
em28xx_init_dev() function, for no reason. Instead, just pass it by
value, which is much more logical and simple.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Thomas Petazzoni authored and Mauro Carvalho Chehab committed Jan 11, 2012
1 parent d07b901 commit 622c2fc
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/media/video/em28xx/em28xx-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -2916,11 +2916,10 @@ void em28xx_release_resources(struct em28xx *dev)
* em28xx_init_dev()
* allocates and inits the device structs, registers i2c bus and v4l device
*/
static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
static int em28xx_init_dev(struct em28xx *dev, struct usb_device *udev,
struct usb_interface *interface,
int minor)
{
struct em28xx *dev = *devhandle;
int retval;

dev->udev = udev;
Expand Down Expand Up @@ -3302,7 +3301,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
/* allocate device struct */
mutex_init(&dev->lock);
mutex_lock(&dev->lock);
retval = em28xx_init_dev(&dev, udev, interface, nr);
retval = em28xx_init_dev(dev, udev, interface, nr);
if (retval) {
goto unlock_and_free;
}
Expand Down

0 comments on commit 622c2fc

Please sign in to comment.