Skip to content

Commit

Permalink
bcm63xx_enet: properly prepare/unprepare clocks before/after usage
Browse files Browse the repository at this point in the history
Use clk_prepare_enable/disable_unprepare calls in preparation for
switching to the generic clock framework.

Signed-off-by: Jonas Gorski <jogo@openwrt.org>
Acked-by: Kevin Cernekee <cernekee@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jonas Gorski authored and David S. Miller committed Mar 10, 2013
1 parent 2a80b5e commit 624e2d2
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/net/ethernet/broadcom/bcm63xx_enet.c
Original file line number Diff line number Diff line change
Expand Up @@ -1670,7 +1670,7 @@ static int bcm_enet_probe(struct platform_device *pdev)
ret = PTR_ERR(priv->mac_clk);
goto out;
}
clk_enable(priv->mac_clk);
clk_prepare_enable(priv->mac_clk);

/* initialize default and fetch platform data */
priv->rx_ring_size = BCMENET_DEF_RX_DESC;
Expand Down Expand Up @@ -1699,7 +1699,7 @@ static int bcm_enet_probe(struct platform_device *pdev)
priv->phy_clk = NULL;
goto out_put_clk_mac;
}
clk_enable(priv->phy_clk);
clk_prepare_enable(priv->phy_clk);
}

/* do minimal hardware init to be able to probe mii bus */
Expand Down Expand Up @@ -1800,12 +1800,12 @@ static int bcm_enet_probe(struct platform_device *pdev)
/* turn off mdc clock */
enet_writel(priv, 0, ENET_MIISC_REG);
if (priv->phy_clk) {
clk_disable(priv->phy_clk);
clk_disable_unprepare(priv->phy_clk);
clk_put(priv->phy_clk);
}

out_put_clk_mac:
clk_disable(priv->mac_clk);
clk_disable_unprepare(priv->mac_clk);
clk_put(priv->mac_clk);
out:
free_netdev(dev);
Expand Down Expand Up @@ -1843,10 +1843,10 @@ static int bcm_enet_remove(struct platform_device *pdev)

/* disable hw block clocks */
if (priv->phy_clk) {
clk_disable(priv->phy_clk);
clk_disable_unprepare(priv->phy_clk);
clk_put(priv->phy_clk);
}
clk_disable(priv->mac_clk);
clk_disable_unprepare(priv->mac_clk);
clk_put(priv->mac_clk);

platform_set_drvdata(pdev, NULL);
Expand Down

0 comments on commit 624e2d2

Please sign in to comment.