Skip to content

Commit

Permalink
9p: Check for NULL fid in v9fs_dir_release()
Browse files Browse the repository at this point in the history
NULL fid should be handled in cases where we endup calling v9fs_dir_release()
before even we instantiate the fid in filp.

Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
  • Loading branch information
jvrao authored and Eric Van Hensbergen committed Sep 13, 2010
1 parent 5c25f34 commit 62726a7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions fs/9p/vfs_dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,11 @@ int v9fs_dir_release(struct inode *inode, struct file *filp)

fid = filp->private_data;
P9_DPRINTK(P9_DEBUG_VFS,
"inode: %p filp: %p fid: %d\n", inode, filp, fid->fid);
"v9fs_dir_release: inode: %p filp: %p fid: %d\n",
inode, filp, fid ? fid->fid : -1);
filemap_write_and_wait(inode->i_mapping);
p9_client_clunk(fid);
if (fid)
p9_client_clunk(fid);
return 0;
}

Expand Down

0 comments on commit 62726a7

Please sign in to comment.