Skip to content

Commit

Permalink
ipv6 sit: Optimize multiple unregistration
Browse files Browse the repository at this point in the history
Speedup module unloading by factorizing synchronize_rcu() calls

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Oct 29, 2009
1 parent d17fa6f commit 62808f9
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions net/ipv6/sit.c
Original file line number Diff line number Diff line change
Expand Up @@ -1145,16 +1145,19 @@ static struct xfrm_tunnel sit_handler = {
.priority = 1,
};

static void sit_destroy_tunnels(struct sit_net *sitn)
static void sit_destroy_tunnels(struct sit_net *sitn, struct list_head *head)
{
int prio;

for (prio = 1; prio < 4; prio++) {
int h;
for (h = 0; h < HASH_SIZE; h++) {
struct ip_tunnel *t;
while ((t = sitn->tunnels[prio][h]) != NULL)
unregister_netdevice(t->dev);
struct ip_tunnel *t = sitn->tunnels[prio][h];

while (t != NULL) {
unregister_netdevice_queue(t->dev, head);
t = t->next;
}
}
}
}
Expand Down Expand Up @@ -1208,11 +1211,13 @@ static int sit_init_net(struct net *net)
static void sit_exit_net(struct net *net)
{
struct sit_net *sitn;
LIST_HEAD(list);

sitn = net_generic(net, sit_net_id);
rtnl_lock();
sit_destroy_tunnels(sitn);
unregister_netdevice(sitn->fb_tunnel_dev);
sit_destroy_tunnels(sitn, &list);
unregister_netdevice_queue(sitn->fb_tunnel_dev, &list);
unregister_netdevice_many(&list);
rtnl_unlock();
kfree(sitn);
}
Expand Down

0 comments on commit 62808f9

Please sign in to comment.