Skip to content

Commit

Permalink
[PATCH] selinux: eliminate selinux_task_ctxid
Browse files Browse the repository at this point in the history
Eliminate selinux_task_ctxid since it duplicates selinux_task_get_sid.

Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: James Morris <jmorris@namei.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Stephen Smalley authored and Linus Torvalds committed Sep 26, 2006
1 parent 89fa302 commit 62bac01
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 25 deletions.
15 changes: 0 additions & 15 deletions include/linux/selinux.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,6 @@ int selinux_audit_rule_match(u32 ctxid, u32 field, u32 op,
*/
void selinux_audit_set_callback(int (*callback)(void));

/**
* selinux_task_ctxid - determine a context ID for a process.
* @tsk: the task object
* @ctxid: ID value returned via this
*
* On return, ctxid will contain an ID for the context. This value
* should only be used opaquely.
*/
void selinux_task_ctxid(struct task_struct *tsk, u32 *ctxid);

/**
* selinux_ctxid_to_string - map a security context ID to a string
* @ctxid: security context ID to be converted.
Expand Down Expand Up @@ -166,11 +156,6 @@ static inline void selinux_audit_set_callback(int (*callback)(void))
return;
}

static inline void selinux_task_ctxid(struct task_struct *tsk, u32 *ctxid)
{
*ctxid = 0;
}

static inline int selinux_ctxid_to_string(u32 ctxid, char **ctx, u32 *ctxlen)
{
*ctx = NULL;
Expand Down
2 changes: 1 addition & 1 deletion kernel/auditsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ static int audit_filter_rules(struct task_struct *tsk,
logged upon error */
if (f->se_rule) {
if (need_sid) {
selinux_task_ctxid(tsk, &sid);
selinux_get_task_sid(tsk, &sid);
need_sid = 0;
}
result = selinux_audit_rule_match(sid, f->type,
Expand Down
9 changes: 0 additions & 9 deletions security/selinux/exports.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@
#include "security.h"
#include "objsec.h"

void selinux_task_ctxid(struct task_struct *tsk, u32 *ctxid)
{
struct task_security_struct *tsec = tsk->security;
if (selinux_enabled)
*ctxid = tsec->sid;
else
*ctxid = 0;
}

int selinux_ctxid_to_string(u32 ctxid, char **ctx, u32 *ctxlen)
{
if (selinux_enabled)
Expand Down

0 comments on commit 62bac01

Please sign in to comment.