Skip to content

Commit

Permalink
kdump: Execute kmsg_dump(KMSG_DUMP_PANIC) after smp_send_stop()
Browse files Browse the repository at this point in the history
This patch moves kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop(),
to serialize the crash-logging process via smp_send_stop() and to
thus retrieve a more stable crash image of all CPUs stopped.

Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Cc: dle-develop@lists.sourceforge.net <dle-develop@lists.sourceforge.net>
Cc: Satoru Moriya <satoru.moriya@hds.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: a.p.zijlstra@chello.nl <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/5C4C569E8A4B9B42A84A977CF070A35B2E4D7A5CE2@USINDEVS01.corp.hds.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Seiji Aguchi authored and Ingo Molnar committed May 18, 2012
1 parent 2a01bb3 commit 62be73e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kernel/panic.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ void panic(const char *fmt, ...)
*/
crash_kexec(NULL);

kmsg_dump(KMSG_DUMP_PANIC);

/*
* Note smp_send_stop is the usual smp shutdown function, which
* unfortunately means it may not be hardened to work in a panic
* situation.
*/
smp_send_stop();

kmsg_dump(KMSG_DUMP_PANIC);

atomic_notifier_call_chain(&panic_notifier_list, 0, buf);

bust_spinlocks(0);
Expand Down

0 comments on commit 62be73e

Please sign in to comment.