Skip to content

Commit

Permalink
[PATCH] x86: Unify pcspeaker platform device code between i386/x86-64
Browse files Browse the repository at this point in the history
Trivial cleanup.

Only change is that it is always compiled in now on x86-64 like on i386.

Signed-off-by: Andi Kleen <ak@suse.de>
  • Loading branch information
Andi Kleen authored and Andi Kleen committed Feb 13, 2007
1 parent 40d22c1 commit 62cc493
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 46 deletions.
1 change: 1 addition & 0 deletions arch/i386/kernel/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ obj-$(CONFIG_K8_NB) += k8.o

obj-$(CONFIG_VMI) += vmi.o vmitime.o
obj-$(CONFIG_PARAVIRT) += paravirt.o
obj-y += pcspeaker.o

EXTRA_AFLAGS := -traditional

Expand Down
20 changes: 20 additions & 0 deletions arch/i386/kernel/pcspeaker.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#include <linux/platform_device.h>
#include <linux/errno.h>
#include <linux/init.h>

static __init int add_pcspkr(void)
{
struct platform_device *pd;
int ret;

pd = platform_device_alloc("pcspkr", -1);
if (!pd)
return -ENOMEM;

ret = platform_device_add(pd);
if (ret)
platform_device_put(pd);

return ret;
}
device_initcall(add_pcspkr);
26 changes: 0 additions & 26 deletions arch/i386/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include <linux/initrd.h>
#include <linux/bootmem.h>
#include <linux/seq_file.h>
#include <linux/platform_device.h>
#include <linux/console.h>
#include <linux/mca.h>
#include <linux/root_dev.h>
Expand Down Expand Up @@ -660,28 +659,3 @@ void __init setup_arch(char **cmdline_p)
#endif
tsc_init();
}

static __init int add_pcspkr(void)
{
struct platform_device *pd;
int ret;

pd = platform_device_alloc("pcspkr", -1);
if (!pd)
return -ENOMEM;

ret = platform_device_add(pd);
if (ret)
platform_device_put(pd);

return ret;
}
device_initcall(add_pcspkr);

/*
* Local Variables:
* mode:c
* c-file-style:"k&r"
* c-basic-offset:8
* End:
*/
2 changes: 2 additions & 0 deletions arch/x86_64/kernel/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ obj-$(CONFIG_PCI) += early-quirks.o

obj-y += topology.o
obj-y += intel_cacheinfo.o
obj-y += pcspeaker.o

CFLAGS_vsyscall.o := $(PROFILING) -g0

Expand All @@ -56,3 +57,4 @@ quirks-y += ../../i386/kernel/quirks.o
i8237-y += ../../i386/kernel/i8237.o
msr-$(subst m,y,$(CONFIG_X86_MSR)) += ../../i386/kernel/msr.o
alternative-y += ../../i386/kernel/alternative.o
pcspeaker-y += ../../i386/kernel/pcspeaker.o
20 changes: 0 additions & 20 deletions arch/x86_64/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -1104,23 +1104,3 @@ struct seq_operations cpuinfo_op = {
.stop = c_stop,
.show = show_cpuinfo,
};

#if defined(CONFIG_INPUT_PCSPKR) || defined(CONFIG_INPUT_PCSPKR_MODULE)
#include <linux/platform_device.h>
static __init int add_pcspkr(void)
{
struct platform_device *pd;
int ret;

pd = platform_device_alloc("pcspkr", -1);
if (!pd)
return -ENOMEM;

ret = platform_device_add(pd);
if (ret)
platform_device_put(pd);

return ret;
}
device_initcall(add_pcspkr);
#endif

0 comments on commit 62cc493

Please sign in to comment.