Skip to content

Commit

Permalink
rtc-wm8350: retries will reach -1
Browse files Browse the repository at this point in the history
With a postfix decrement retries will reach -1 rather than 0, so the
warning and error-out will not occur.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Roel Kluin authored and Linus Torvalds committed Apr 1, 2009
1 parent a216685 commit 62da659
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/rtc/rtc-wm8350.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ static int wm8350_rtc_settime(struct device *dev, struct rtc_time *tm)
do {
rtc_ctrl = wm8350_reg_read(wm8350, WM8350_RTC_TIME_CONTROL);
schedule_timeout_uninterruptible(msecs_to_jiffies(1));
} while (retries-- && !(rtc_ctrl & WM8350_RTC_STS));
} while (--retries && !(rtc_ctrl & WM8350_RTC_STS));

if (!retries) {
dev_err(dev, "timed out on set confirmation\n");
Expand Down Expand Up @@ -437,7 +437,7 @@ static int wm8350_rtc_probe(struct platform_device *pdev)
do {
timectl = wm8350_reg_read(wm8350,
WM8350_RTC_TIME_CONTROL);
} while (timectl & WM8350_RTC_STS && retries--);
} while (timectl & WM8350_RTC_STS && --retries);

if (retries == 0) {
dev_err(&pdev->dev, "failed to start: timeout\n");
Expand Down

0 comments on commit 62da659

Please sign in to comment.