Skip to content

Commit

Permalink
[PATCH] i386: replace spin_lock_irqsave with spin_lock
Browse files Browse the repository at this point in the history
IRQ is already disabled through local_irq_disable().  So
spin_lock_irqsave() can be replaced with spin_lock().

Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
Hisashi Hifumi authored and Andi Kleen committed May 2, 2007
1 parent e8a72ff commit 62dbc21
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions arch/i386/kernel/reboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,6 @@ static unsigned char jump_to_bios [] =
*/
void machine_real_restart(unsigned char *code, int length)
{
unsigned long flags;

local_irq_disable();

/* Write zero to CMOS register number 0x0f, which the BIOS POST
Expand All @@ -212,9 +210,9 @@ void machine_real_restart(unsigned char *code, int length)
safe side. (Yes, CMOS_WRITE does outb_p's. - Paul G.)
*/

spin_lock_irqsave(&rtc_lock, flags);
spin_lock(&rtc_lock);
CMOS_WRITE(0x00, 0x8f);
spin_unlock_irqrestore(&rtc_lock, flags);
spin_unlock(&rtc_lock);

/* Remap the kernel at virtual address zero, as well as offset zero
from the kernel segment. This assumes the kernel segment starts at
Expand Down

0 comments on commit 62dbc21

Please sign in to comment.