Skip to content

Commit

Permalink
USB: storage: onetouch: clean up urb->status usage
Browse files Browse the repository at this point in the history
This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jul 20, 2007
1 parent 18ac301 commit 62e5a33
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions drivers/usb/storage/onetouch.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ static void usb_onetouch_irq(struct urb *urb)
struct usb_onetouch *onetouch = urb->context;
signed char *data = onetouch->data;
struct input_dev *dev = onetouch->dev;
int status;
int status = urb->status;
int retval;

switch (urb->status) {
switch (status) {
case 0: /* success */
break;
case -ECONNRESET: /* unlink */
Expand All @@ -75,11 +76,11 @@ static void usb_onetouch_irq(struct urb *urb)
input_sync(dev);

resubmit:
status = usb_submit_urb (urb, GFP_ATOMIC);
if (status)
err ("can't resubmit intr, %s-%s/input0, status %d",
retval = usb_submit_urb (urb, GFP_ATOMIC);
if (retval)
err ("can't resubmit intr, %s-%s/input0, retval %d",
onetouch->udev->bus->bus_name,
onetouch->udev->devpath, status);
onetouch->udev->devpath, retval);
}

static int usb_onetouch_open(struct input_dev *dev)
Expand Down

0 comments on commit 62e5a33

Please sign in to comment.