Skip to content

Commit

Permalink
p54spi: Release GPIO lines and IRQ on error in p54spi_probe
Browse files Browse the repository at this point in the history
This makes it possible to reload driver if insmod has failed due to
missing firmware.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Cc: stable <stable@vger.kernel.org>
Acked-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Max Filippov authored and John W. Linville committed Mar 5, 2012
1 parent 461bc26 commit 62ebeed
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions drivers/net/wireless/p54/p54spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -618,19 +618,19 @@ static int __devinit p54spi_probe(struct spi_device *spi)
ret = spi_setup(spi);
if (ret < 0) {
dev_err(&priv->spi->dev, "spi_setup failed");
goto err_free_common;
goto err_free;
}

ret = gpio_request(p54spi_gpio_power, "p54spi power");
if (ret < 0) {
dev_err(&priv->spi->dev, "power GPIO request failed: %d", ret);
goto err_free_common;
goto err_free;
}

ret = gpio_request(p54spi_gpio_irq, "p54spi irq");
if (ret < 0) {
dev_err(&priv->spi->dev, "irq GPIO request failed: %d", ret);
goto err_free_common;
goto err_free_gpio_power;
}

gpio_direction_output(p54spi_gpio_power, 0);
Expand All @@ -641,7 +641,7 @@ static int __devinit p54spi_probe(struct spi_device *spi)
priv->spi);
if (ret < 0) {
dev_err(&priv->spi->dev, "request_irq() failed");
goto err_free_common;
goto err_free_gpio_irq;
}

irq_set_irq_type(gpio_to_irq(p54spi_gpio_irq), IRQ_TYPE_EDGE_RISING);
Expand Down Expand Up @@ -673,6 +673,12 @@ static int __devinit p54spi_probe(struct spi_device *spi)
return 0;

err_free_common:
free_irq(gpio_to_irq(p54spi_gpio_irq), spi);
err_free_gpio_irq:
gpio_free(p54spi_gpio_irq);
err_free_gpio_power:
gpio_free(p54spi_gpio_power);
err_free:
p54_free_common(priv->hw);
return ret;
}
Expand Down

0 comments on commit 62ebeed

Please sign in to comment.