Skip to content

Commit

Permalink
[media] cx24117: remove dead code in always 'false' if statement
Browse files Browse the repository at this point in the history
At this point of the execution in the function cx24117_attach()
demod cannot be '0'. In that case the function returns earlier
with an error value ('NULL'). Remove the if statement.

This error has been reported by scan.coverity.com

Signed-off-by: Andi Shyti <andi@etezian.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
  • Loading branch information
Andi Shyti authored and Mauro Carvalho Chehab committed Feb 4, 2014
1 parent 08e1097 commit 62fd0d3
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/media/dvb-frontends/cx24117.c
Original file line number Diff line number Diff line change
Expand Up @@ -1200,12 +1200,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config,
state->demod = demod - 1;
state->priv = priv;

/* test i2c bus for ack */
if (demod == 0) {
if (cx24117_readreg(state, 0x00) < 0)
goto error3;
}

dev_info(&state->priv->i2c->dev,
"%s: Attaching frontend %d\n",
KBUILD_MODNAME, state->demod);
Expand All @@ -1216,8 +1210,6 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config,
state->frontend.demodulator_priv = state;
return &state->frontend;

error3:
kfree(state);
error2:
cx24117_release_priv(priv);
error1:
Expand Down

0 comments on commit 62fd0d3

Please sign in to comment.