Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 346002
b: refs/heads/master
c: ff370e5
h: refs/heads/master
v: v3
  • Loading branch information
Philipp Reisner committed Nov 8, 2012
1 parent 8a42e93 commit 631f841
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 5cc287e0ae77bef615a046a44e17e1d68e23dbb7
refs/heads/master: ff370e5a9ebaf9499431216a531a196d98283228
2 changes: 1 addition & 1 deletion trunk/drivers/block/drbd/drbd_int.h
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,7 @@ extern rwlock_t global_state_lock;
extern int conn_lowest_minor(struct drbd_tconn *tconn);
enum drbd_ret_code conn_new_minor(struct drbd_tconn *tconn, unsigned int minor, int vnr);
extern void drbd_free_mdev(struct drbd_conf *mdev);
extern void drbd_delete_device(unsigned int minor);
extern void drbd_delete_device(struct drbd_conf *mdev);

struct drbd_tconn *drbd_new_tconn(const char *name);
extern void drbd_free_tconn(struct drbd_tconn *tconn);
Expand Down
12 changes: 4 additions & 8 deletions trunk/drivers/block/drbd/drbd_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2204,15 +2204,10 @@ static void drbd_release_all_peer_reqs(struct drbd_conf *mdev)
}

/* caution. no locking. */
void drbd_delete_device(unsigned int minor)
void drbd_delete_device(struct drbd_conf *mdev)
{
struct drbd_conf *mdev = minor_to_mdev(minor);

if (!mdev)
return;

idr_remove(&mdev->tconn->volumes, mdev->vnr);
idr_remove(&minors, minor);
idr_remove(&minors, mdev_to_minor(mdev));
synchronize_rcu();

/* paranoia asserts */
Expand Down Expand Up @@ -2265,7 +2260,8 @@ static void drbd_cleanup(void)
drbd_genl_unregister();

idr_for_each_entry(&minors, mdev, i)
drbd_delete_device(i);
drbd_delete_device(mdev);

drbd_destroy_mempools();
unregister_blkdev(DRBD_MAJOR, "drbd");

Expand Down
2 changes: 1 addition & 1 deletion trunk/drivers/block/drbd/drbd_nl.c
Original file line number Diff line number Diff line change
Expand Up @@ -2861,7 +2861,7 @@ static enum drbd_ret_code adm_delete_minor(struct drbd_conf *mdev)
* we may want to delete a minor from a live replication group.
*/
mdev->state.role == R_SECONDARY) {
drbd_delete_device(mdev_to_minor(mdev));
drbd_delete_device(mdev);
return NO_ERROR;
} else
return ERR_MINOR_CONFIGURED;
Expand Down

0 comments on commit 631f841

Please sign in to comment.