---

yaml --- r: 143738 b: refs/heads/master c: 8a577ff h: refs/heads/master v: v3
git-mirror · Apr 20, 2009 · 6323c4d · 6323c4d
1 parent 6988d80
commit 6323c4d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: d91dfbb41bb2e9bdbfbd2cc7078ed7436eab027a
+refs/heads/master: 8a577ffc75d9194fe8cdb7479236f2081c26ca1f
diff --git a/trunk/drivers/base/core.c b/trunk/drivers/base/core.c
@@ -891,7 +891,8 @@ int device_add(struct device *dev)
 		set_dev_node(dev, dev_to_node(parent));
 
 	/* first, register with generic layer. */
-	error = kobject_add(&dev->kobj, dev->kobj.parent, "%s", dev_name(dev));
+	/* we require the name to be set before, and pass NULL */
+	error = kobject_add(&dev->kobj, dev->kobj.parent, NULL);
 	if (error)
 		goto Error;
 

diff --git a/trunk/lib/kobject.c b/trunk/lib/kobject.c
@@ -218,6 +218,9 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
 	const char *old_name = kobj->name;
 	char *s;
 
+	if (kobj->name && !fmt)
+		return 0;
+
 	kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
 	if (!kobj->name)
 		return -ENOMEM;