Skip to content

Commit

Permalink
staging/mei: mei-amt-version - make all function static and used
Browse files Browse the repository at this point in the history
This patch eliminates following type of warnings
warning: no previous prototype for '...func...' [-Wmissing-prototypes]

For this is a single file example lets make all API-like functions
be static.
Since all static functions should be used so let's call
to amt_host_if_deinit() even if in this example it's not really necessary

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Tomas Winkler authored and Greg Kroah-Hartman committed Feb 24, 2012
1 parent 4b00706 commit 63319ba
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions drivers/staging/mei/mei-amt-version.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,21 +293,21 @@ struct amt_host_if {
};


bool amt_host_if_init(struct amt_host_if *acmd,
static bool amt_host_if_init(struct amt_host_if *acmd,
unsigned long send_timeout, bool verbose)
{
acmd->send_timeout = (send_timeout) ? send_timeout : 20000;
acmd->initialized = mei_init(&acmd->mei_cl, &MEI_IAMTHIF, 0, verbose);
return acmd->initialized;
}

void amt_host_if_deinit(struct amt_host_if *acmd)
static void amt_host_if_deinit(struct amt_host_if *acmd)
{
mei_deinit(&acmd->mei_cl);
acmd->initialized = false;
}

uint32_t amt_verify_code_versions(const struct amt_host_if_resp_header *resp)
static uint32_t amt_verify_code_versions(const struct amt_host_if_resp_header *resp)
{
uint32_t status = AMT_STATUS_SUCCESS;
struct amt_code_versions *code_ver;
Expand Down Expand Up @@ -346,7 +346,7 @@ uint32_t amt_verify_code_versions(const struct amt_host_if_resp_header *resp)
return status;
}

uint32_t amt_verify_response_header(uint32_t command,
static uint32_t amt_verify_response_header(uint32_t command,
const struct amt_host_if_msg_header *resp_hdr,
uint32_t response_size)
{
Expand Down Expand Up @@ -409,7 +409,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
}


uint32_t amt_get_code_versions(struct amt_host_if *cmd,
static uint32_t amt_get_code_versions(struct amt_host_if *cmd,
struct amt_code_versions *versions)
{
struct amt_host_if_resp_header *response = NULL;
Expand Down Expand Up @@ -455,6 +455,8 @@ int main(int argc, char **argv)

status = amt_get_code_versions(&acmd, &ver);

amt_host_if_deinit(&acmd);

switch (status) {
case AMT_STATUS_HOST_IF_EMPTY_RESPONSE:
printf("Intel AMT: DISABLED\n");
Expand Down

0 comments on commit 63319ba

Please sign in to comment.