Skip to content

Commit

Permalink
OMAP: hwmod: Replace WARN by pr_warning for clockdomain check
Browse files Browse the repository at this point in the history
Most of the clock nodes belong to a clock domain, but it is perfectly valid
to have clock without clock domain.
Root clocks for example does not belong to any clock domain.
Keep the warning but reduce the verbosity.

Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
  • Loading branch information
Benoit Cousson authored and Paul Walmsley committed May 20, 2010
1 parent 5c2c029 commit 6340338
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions arch/arm/mach-omap2/omap_hwmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -404,21 +404,20 @@ static int _del_initiator_dep(struct omap_hwmod *oh, struct omap_hwmod *init_oh)
*/
static int _init_main_clk(struct omap_hwmod *oh)
{
struct clk *c;
int ret = 0;

if (!oh->main_clk)
return 0;

c = omap_clk_get_by_name(oh->main_clk);
if (!c)
oh->_clk = omap_clk_get_by_name(oh->main_clk);
if (!oh->_clk)
pr_warning("omap_hwmod: %s: cannot clk_get main_clk %s\n",
oh->name, oh->main_clk);
ret = -EINVAL;
oh->_clk = c;
return -EINVAL;

WARN(!c->clkdm, "omap_hwmod: %s: missing clockdomain for %s.\n",
oh->main_clk, c->name);
if (!oh->_clk->clkdm)
pr_warning("omap_hwmod: %s: missing clockdomain for %s.\n",
oh->main_clk, oh->_clk->name);

return ret;
}
Expand Down

0 comments on commit 6340338

Please sign in to comment.