Skip to content

Commit

Permalink
pinctrl/lantiq: add output pinconf parameter
Browse files Browse the repository at this point in the history
While converting the boards inside OpenWrt to OF I noticed
that the we are missing a pinconf parameter to set a pin
to output.

Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
  • Loading branch information
John Crispin authored and Linus Walleij committed Feb 5, 2013
1 parent 3a6b04c commit 6360350
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/pinctrl/pinctrl-lantiq.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ enum ltq_pinconf_param {
LTQ_PINCONF_PARAM_OPEN_DRAIN,
LTQ_PINCONF_PARAM_DRIVE_CURRENT,
LTQ_PINCONF_PARAM_SLEW_RATE,
LTQ_PINCONF_PARAM_OUTPUT,
};

struct ltq_cfg_param {
Expand Down
14 changes: 14 additions & 0 deletions drivers/pinctrl/pinctrl-xway.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,11 @@ static int xway_pinconf_get(struct pinctrl_dev *pctldev,
*config = LTQ_PINCONF_PACK(param, 1);
break;

case LTQ_PINCONF_PARAM_OUTPUT:
reg = GPIO_DIR(pin);
*config = LTQ_PINCONF_PACK(param,
gpio_getbit(info->membase[0], reg, PORT_PIN(pin)));
break;
default:
dev_err(pctldev->dev, "Invalid config param %04x\n", param);
return -ENOTSUPP;
Expand Down Expand Up @@ -515,6 +520,14 @@ static int xway_pinconf_set(struct pinctrl_dev *pctldev,
dev_err(pctldev->dev, "Invalid pull value %d\n", arg);
break;

case LTQ_PINCONF_PARAM_OUTPUT:
reg = GPIO_DIR(pin);
if (arg == 0)
gpio_clearbit(info->membase[0], reg, PORT_PIN(pin));
else
gpio_setbit(info->membase[0], reg, PORT_PIN(pin));
break;

default:
dev_err(pctldev->dev, "Invalid config param %04x\n", param);
return -ENOTSUPP;
Expand Down Expand Up @@ -573,6 +586,7 @@ static inline int xway_mux_apply(struct pinctrl_dev *pctrldev,
static const struct ltq_cfg_param xway_cfg_params[] = {
{"lantiq,pull", LTQ_PINCONF_PARAM_PULL},
{"lantiq,open-drain", LTQ_PINCONF_PARAM_OPEN_DRAIN},
{"lantiq,output", LTQ_PINCONF_PARAM_OUTPUT},
};

static struct ltq_pinmux_info xway_info = {
Expand Down

0 comments on commit 6360350

Please sign in to comment.