Skip to content

Commit

Permalink
isci: Device access in the error path does not depend on IDEV_GONE.
Browse files Browse the repository at this point in the history
Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Jeff Skirvin authored and Dan Williams committed May 17, 2012
1 parent 59e3539 commit 6373250
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/scsi/isci/task.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ int isci_task_lu_reset(struct domain_device *dev, u8 *lun)
int ret;

spin_lock_irqsave(&ihost->scic_lock, flags);
idev = isci_lookup_device(dev);
idev = isci_get_device(dev->lldd_dev);
spin_unlock_irqrestore(&ihost->scic_lock, flags);

dev_dbg(&ihost->pdev->dev,
Expand Down Expand Up @@ -507,7 +507,7 @@ int isci_task_abort_task(struct sas_task *task)
if (!(task->task_state_flags & SAS_TASK_STATE_DONE) &&
(task->task_state_flags & SAS_TASK_AT_INITIATOR) &&
old_request)
idev = isci_lookup_device(task->dev);
idev = isci_get_device(task->dev->lldd_dev);

spin_unlock(&task->task_state_lock);
spin_unlock_irqrestore(&ihost->scic_lock, flags);
Expand Down Expand Up @@ -593,6 +593,9 @@ int isci_task_abort_task(struct sas_task *task)
ISCI_ABORT_TASK_TIMEOUT_MS);
}
out:
dev_warn(&ihost->pdev->dev,
"%s: Done; dev = %p, task = %p , old_request == %p\n",
__func__, idev, task, old_request);
isci_put_device(idev);
return ret;
}
Expand Down

0 comments on commit 6373250

Please sign in to comment.