Skip to content

Commit

Permalink
tm6000: Remove some ugly debug code
Browse files Browse the repository at this point in the history
Those time debugs were here just while developing the driver. They are
not really needed, as kernel may be configured to print jiffies with
printk's. Also, it breaks, if more than one device is connected.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Oct 23, 2010
1 parent fcb9757 commit 638054a
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/staging/tm6000/tm6000-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req,
{
int ret, i;
unsigned int pipe;
static int ini = 0, last = 0, n = 0;
u8 *data = NULL;

if (len)
Expand All @@ -52,19 +51,12 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req,
}

if (tm6000_debug & V4L2_DEBUG_I2C) {
if (!ini)
last = ini = jiffies;
printk("(dev %p, pipe %08x): ", dev->udev, pipe);

printk("%06i (dev %p, pipe %08x): ", n, dev->udev, pipe);

printk("%s: %06u ms %06u ms %02x %02x %02x %02x %02x %02x %02x %02x ",
printk("%s: %02x %02x %02x %02x %02x %02x %02x %02x ",
(req_type & USB_DIR_IN) ? " IN" : "OUT",
jiffies_to_msecs(jiffies-last),
jiffies_to_msecs(jiffies-ini),
req_type, req, value&0xff, value>>8, index&0xff,
index>>8, len&0xff, len>>8);
last = jiffies;
n++;

if (!(req_type & USB_DIR_IN)) {
printk(">>> ");
Expand Down

0 comments on commit 638054a

Please sign in to comment.