Skip to content

Commit

Permalink
x86: add ->pre_time_init to x86_quirks
Browse files Browse the repository at this point in the history
so NUMAQ can use that to call numaq_pre_time_init()

This allows us to remove a NUMAQ special from arch/x86/kernel/setup.c.

(and paves the way to remove the NUMAQ subarch)

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Yinghai Lu authored and Ingo Molnar committed Jul 20, 2008
1 parent 64898a8 commit 63b5d7a
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 8 deletions.
7 changes: 7 additions & 0 deletions arch/x86/kernel/numaq_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ void __init numaq_tsc_disable(void)
}
}

static int __init numaq_pre_time_init(void)
{
numaq_tsc_disable();
return 0;
}

int found_numaq;
/*
* Have to match translation table entries to main table entries by counter
Expand Down Expand Up @@ -224,6 +230,7 @@ static void __init smp_read_mpc_oem(struct mp_config_oemtable *oemtable,
}

static struct x86_quirks numaq_x86_quirks __initdata = {
.arch_pre_time_init = numaq_pre_time_init,
.arch_time_init = NULL,
.arch_pre_intr_init = NULL,
.arch_memory_setup = NULL,
Expand Down
8 changes: 0 additions & 8 deletions arch/x86/kernel/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -853,14 +853,6 @@ void __init setup_arch(char **cmdline_p)
init_cpu_to_node();
#endif

#ifdef CONFIG_X86_NUMAQ
/*
* need to check online nodes num, call it
* here before time_init/tsc_init
*/
numaq_tsc_disable();
#endif

init_apic_mappings();
ioapic_init_mappings();

Expand Down
1 change: 1 addition & 0 deletions arch/x86/kernel/time_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ void __init hpet_time_init(void)
*/
void __init time_init(void)
{
pre_time_init_hook();
tsc_init();
late_time_init = choose_time_init();
}
10 changes: 10 additions & 0 deletions arch/x86/mach-default/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,16 @@ static struct irqaction irq0 = {
.name = "timer"
};

/**
* pre_time_init_hook - do any specific initialisations before.
*
**/
void __init pre_time_init_hook(void)
{
if (x86_quirks->arch_pre_time_init)
x86_quirks->arch_pre_time_init();
}

/**
* time_init_hook - do any specific initialisations for the system timer.
*
Expand Down
1 change: 1 addition & 0 deletions include/asm-x86/arch_hooks.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ extern void intr_init_hook(void);
extern void pre_intr_init_hook(void);
extern void pre_setup_arch_hook(void);
extern void trap_init_hook(void);
extern void pre_time_init_hook(void);
extern void time_init_hook(void);
extern void mca_nmi_hook(void);

Expand Down
1 change: 1 addition & 0 deletions include/asm-x86/setup.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ struct mpc_config_processor;
struct mpc_config_bus;
struct mp_config_oemtable;
struct x86_quirks {
int (*arch_pre_time_init)(void);
int (*arch_time_init)(void);
int (*arch_pre_intr_init)(void);
int (*arch_intr_init)(void);
Expand Down

0 comments on commit 63b5d7a

Please sign in to comment.