Skip to content

Commit

Permalink
staging: comedi: pass struct comedi_driver * to comedi_auto_config()
Browse files Browse the repository at this point in the history
Pass a pointer to the struct comedi_driver to comedi_auto_config()
instead of the driver name.  comedi_auto_config() will be changed to
make use of this.  It currently calls comedi_device_attach() which
examines the whole list of struct comedi_driver objects.  It will be
changed to restrict itself to just the supplied struct comedi_driver
object.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ian Abbott authored and Greg Kroah-Hartman committed Apr 10, 2012
1 parent f401167 commit 63bf3d1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/staging/comedi/drivers.c
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ comedi_auto_config_helper(struct device *hardware_device,
}

static int comedi_auto_config(struct device *hardware_device,
const char *board_name, const int *options,
struct comedi_driver *driver, const int *options,
unsigned num_options)
{
struct comedi_devconfig it;
Expand All @@ -875,7 +875,7 @@ static int comedi_auto_config(struct device *hardware_device,
dev_file_info = comedi_get_device_file_info(minor);

memset(&it, 0, sizeof(it));
strncpy(it.board_name, board_name, COMEDI_NAMELEN);
strncpy(it.board_name, driver->driver_name, COMEDI_NAMELEN);
it.board_name[COMEDI_NAMELEN - 1] = '\0';
BUG_ON(num_options > COMEDI_NDEVCONFOPTS);
memcpy(it.options, options, num_options * sizeof(int));
Expand Down Expand Up @@ -912,7 +912,7 @@ static int comedi_old_pci_auto_config(struct pci_dev *pcidev,
/* pci slot */
options[1] = PCI_SLOT(pcidev->devfn);

return comedi_auto_config(&pcidev->dev, driver->driver_name,
return comedi_auto_config(&pcidev->dev, driver,
options, ARRAY_SIZE(options));
}

Expand Down Expand Up @@ -947,7 +947,7 @@ EXPORT_SYMBOL_GPL(comedi_pci_auto_unconfig);
static int comedi_old_usb_auto_config(struct usb_interface *intf,
struct comedi_driver *driver)
{
return comedi_auto_config(&intf->dev, driver->driver_name, NULL, 0);
return comedi_auto_config(&intf->dev, driver, NULL, 0);
}

static int comedi_usb_attach_wrapper(struct comedi_device *dev, void *intf)
Expand Down

0 comments on commit 63bf3d1

Please sign in to comment.