Skip to content

Commit

Permalink
rhashtable: Add rehash counter to bucket_table
Browse files Browse the repository at this point in the history
This patch adds a rehash counter to bucket_table to indicate
the last bucket that has been rehashed.  This serves two purposes:

1. Any bucket that has been rehashed can never gain a new object.
2. If the rehash counter reaches the size of the table, the table
will forever remain empty.

This patch also downsizes bucket_table->size to an unsigned int
since we do not support sizes greater than 32 bits yet.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Herbert Xu authored and David S. Miller committed Mar 15, 2015
1 parent 9d901bc commit 63d512d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion include/linux/rhashtable.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ struct rhash_head {
/**
* struct bucket_table - Table of hash buckets
* @size: Number of hash buckets
* @rehash: Current bucket being rehashed
* @hash_rnd: Random seed to fold into hash
* @shift: Current size (1 << shift)
* @locks_mask: Mask to apply before accessing locks[]
Expand All @@ -58,7 +59,8 @@ struct rhash_head {
* @buckets: size * hash buckets
*/
struct bucket_table {
size_t size;
unsigned int size;
unsigned int rehash;
u32 hash_rnd;
u32 shift;
unsigned int locks_mask;
Expand Down
1 change: 1 addition & 0 deletions lib/rhashtable.c
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ static void rhashtable_rehash_chain(struct rhashtable *ht, unsigned old_hash)
spin_lock_bh(old_bucket_lock);
while (!rhashtable_rehash_one(ht, old_hash))
;
old_tbl->rehash++;
spin_unlock_bh(old_bucket_lock);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/test_rhashtable.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ static void test_bucket_stats(struct rhashtable *ht, bool quiet)
rcu_cnt = cnt = 0;

if (!quiet)
pr_info(" [%#4x/%zu]", i, tbl->size);
pr_info(" [%#4x/%u]", i, tbl->size);

rht_for_each_entry_rcu(obj, pos, tbl, i, node) {
cnt++;
Expand Down

0 comments on commit 63d512d

Please sign in to comment.