Skip to content

Commit

Permalink
[PATCH] iwlwifi: removing unnecessary memset in 4965 rate scale
Browse files Browse the repository at this point in the history
This patch removes redundant memset in rate scale. In rs_alloc_sta,
kzalloc is used so the memset can be avoided. In rs_rate_init, it is
a bug fix since it overrides everything set in other handlers namely
add_debugfs.

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Zhu Yi authored and David S. Miller committed Oct 10, 2007
1 parent c14c521 commit 63fddb9
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/net/wireless/iwlwifi/iwl-4965-rs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1776,10 +1776,9 @@ static void *rs_alloc_sta(void *priv, gfp_t gfp)

if (crl == NULL)
return NULL;

memset(crl, 0, sizeof(struct iwl_rate_scale_priv));
crl->lq.sta_id = 0xff;


for (j = 0; j < LQ_SIZE; j++)
for (i = 0; i < IWL_RATE_COUNT; i++)
rs_rate_scale_clear_window(&(crl->lq_info[j].win[i]));
Expand All @@ -1796,9 +1795,6 @@ static void rs_rate_init(void *priv_rate, void *priv_sta,
struct iwl_priv *priv = (struct iwl_priv *)priv_rate;
struct iwl_rate_scale_priv *crl = priv_sta;

memset(crl, 0, sizeof(struct iwl_rate_scale_priv));

crl->lq.sta_id = 0xff;
crl->flush_timer = 0;
sta->txrate = 3;
for (j = 0; j < LQ_SIZE; j++)
Expand Down

0 comments on commit 63fddb9

Please sign in to comment.