Skip to content

Commit

Permalink
OMAP24xx: CM: fix mask used for checking IDLEST status
Browse files Browse the repository at this point in the history
On OMAP24xx, the polarity for the IDLEST bits is opposite of OMAP3.
The mask used to check this was using the bit position instead of the
bit mask.

This patch fixes the problem by using the bit mask instead of the bit
field.

Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
  • Loading branch information
Kevin Hilman authored and Paul Walmsley committed Jul 26, 2010
1 parent fb2fc92 commit 6405616
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/arm/mach-omap2/cm.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ int omap2_cm_wait_module_ready(s16 prcm_mod, u8 idlest_id, u8 idlest_shift)

cm_idlest_reg = cm_idlest_offs[idlest_id - 1];

mask = 1 << idlest_shift;

if (cpu_is_omap24xx())
ena = idlest_shift;
ena = mask;
else if (cpu_is_omap34xx())
ena = 0;
else
BUG();

mask = 1 << idlest_shift;

/* XXX should be OMAP2 CM */
omap_test_timeout(((cm_read_mod_reg(prcm_mod, cm_idlest_reg) & mask) == ena),
MAX_MODULE_READY_TIME, i);
Expand Down

0 comments on commit 6405616

Please sign in to comment.