Skip to content

Commit

Permalink
ALSA: pcsp: Fix the order of input device unregistration
Browse files Browse the repository at this point in the history
The current code may access to the already freed object.  The input
device must be accessed and unregistered before freeing the top level
sound object.

Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Iwai committed Nov 14, 2013
1 parent 44832a7 commit 6408eac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/drivers/pcsp/pcsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,8 @@ static int pcsp_probe(struct platform_device *dev)
static int pcsp_remove(struct platform_device *dev)
{
struct snd_pcsp *chip = platform_get_drvdata(dev);
alsa_card_pcsp_exit(chip);
pcspkr_input_remove(chip->input_dev);
alsa_card_pcsp_exit(chip);
return 0;
}

Expand Down

0 comments on commit 6408eac

Please sign in to comment.