Skip to content

Commit

Permalink
ASoC: remove bogus SLEEP mode from wm8978 driver
Browse files Browse the repository at this point in the history
Tests showed, that bit 6 of the WM8978_POWER_MANAGEMENT_2 register of wm8978
affects codec clocks. Being useless for suspend / resume, it cannot be used in
bias-level control either. Remove this bit handling.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Guennadi Liakhovetski authored and Mark Brown committed Jan 29, 2010
1 parent 9f5b64b commit 640b796
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions sound/soc/codecs/wm8978.c
Original file line number Diff line number Diff line change
Expand Up @@ -873,8 +873,6 @@ static int wm8978_suspend(struct platform_device *pdev, pm_message_t state)
wm8978_set_bias_level(codec, SND_SOC_BIAS_OFF);
/* Also switch PLL off */
snd_soc_write(codec, WM8978_POWER_MANAGEMENT_1, 0);
/* Put to sleep */
snd_soc_write(codec, WM8978_POWER_MANAGEMENT_2, 0x40);

return 0;
}
Expand All @@ -887,9 +885,6 @@ static int wm8978_resume(struct platform_device *pdev)
int i;
u16 *cache = codec->reg_cache;

/* Wake up the codec */
snd_soc_write(codec, WM8978_POWER_MANAGEMENT_2, 0);

/* Sync reg_cache with the hardware */
for (i = 0; i < ARRAY_SIZE(wm8978_reg); i++) {
if (i == WM8978_RESET)
Expand Down

0 comments on commit 640b796

Please sign in to comment.