Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 83214
b: refs/heads/master
c: cfef8f3
h: refs/heads/master
v: v3
  • Loading branch information
Jeff Dike authored and Linus Torvalds committed Feb 5, 2008
1 parent 2280b95 commit 64162dc
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 22 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d7b88513c504e49d450b0f89f80ba9d451a3c804
refs/heads/master: cfef8f34e7cf57f3d278ceda79c85112dec13dc6
33 changes: 12 additions & 21 deletions trunk/arch/um/os-Linux/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ static void sig_handler_common(int sig, struct sigcontext *sc)
#define SIGVTALRM_MASK (1 << SIGVTALRM_BIT)

static int signals_enabled;
static unsigned int pending;
static unsigned int signals_pending;

void sig_handler(int sig, struct sigcontext *sc)
{
int enabled;

enabled = signals_enabled;
if (!enabled && (sig == SIGIO)) {
pending |= SIGIO_MASK;
signals_pending |= SIGIO_MASK;
return;
}

Expand Down Expand Up @@ -99,7 +99,7 @@ void alarm_handler(int sig, struct sigcontext *sc)

enabled = signals_enabled;
if (!signals_enabled) {
pending |= SIGVTALRM_MASK;
signals_pending |= SIGVTALRM_MASK;
return;
}

Expand All @@ -125,16 +125,6 @@ void set_sigstack(void *sig_stack, int size)
panic("enabling signal stack failed, errno = %d\n", errno);
}

void remove_sigstack(void)
{
stack_t stack = ((stack_t) { .ss_flags = SS_DISABLE,
.ss_sp = NULL,
.ss_size = 0 });

if (sigaltstack(&stack, NULL) != 0)
panic("disabling signal stack failed, errno = %d\n", errno);
}

void (*handlers[_NSIG])(int sig, struct sigcontext *sc);

void handle_signal(int sig, struct sigcontext *sc)
Expand Down Expand Up @@ -213,13 +203,14 @@ void set_handler(int sig, void (*handler)(int), int flags, ...)

int change_sig(int signal, int on)
{
sigset_t sigset, old;
sigset_t sigset;

sigemptyset(&sigset);
sigaddset(&sigset, signal);
if (sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, &old) < 0)
if (sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, NULL) < 0)
return -errno;
return !sigismember(&old, signal);

return 0;
}

void block_signals(void)
Expand All @@ -244,26 +235,26 @@ void unblock_signals(void)
/*
* We loop because the IRQ handler returns with interrupts off. So,
* interrupts may have arrived and we need to re-enable them and
* recheck pending.
* recheck signals_pending.
*/
while(1) {
/*
* Save and reset save_pending after enabling signals. This
* way, pending won't be changed while we're reading it.
* way, signals_pending won't be changed while we're reading it.
*/
signals_enabled = 1;

/*
* Setting signals_enabled and reading pending must
* Setting signals_enabled and reading signals_pending must
* happen in this order.
*/
barrier();

save_pending = pending;
save_pending = signals_pending;
if (save_pending == 0)
return;

pending = 0;
signals_pending = 0;

/*
* We have pending interrupts, so disable signals, as the
Expand Down

0 comments on commit 64162dc

Please sign in to comment.